CRITICAL: Kill areChatRoomsEnabled beta everywhere

[quinthar]

Note: Decided here:

Strategy:
Not every feature is ready for a billion people to use. For this reason, we often put works in progress behind "betas" so we can test with some without risking premature exposure to others.

Problem:
While building out User Created Rooms (aka "workspace rooms"), we have hidden this functionality behind the areChatRoomsEnabled beta. This flags which specific policies are eligible to have rooms. Right now this is set as true by default for all Free workspaces, but can be set manually for others. However, at this time there's no reason to limit this to any specific workspaces, all are eligible.

Solution:
Find every instance of areChatRoomsEnabled and remove. This means:

1. Don't set it on new Free workspaces
2. Don't check it anywhere, on the client or server

[iwiznia]

Sent the 3 PRs for this

[quinthar]

I think this is done.

[jasperhuangg]

Were the changes for this reverted? After a quick search I still see areChatRoomsEnabled in some places in App

#34934

[jasperhuangg]

cc @quinthar @iwiznia

[iwiznia]

I am so confused. I think someone re-added them for some reason?
I checked out the commit from my PR and there's no references to areChatRoomsEnabled there 😕

[jasperhuangg]

@iwiznia it looks like your PR was reverted #34311

[jasperhuangg]

Do you want to take over on #34934 since you were assigned to this issue originally?

[iwiznia]

Well, first off, if you revert a PR, you should ping the person that created, I could've never known it was reverted otherwise.
But more importantly, I see nowhere the reason why it was reverted.

[jasperhuangg]

cc @thienlnam 🙇 do you have any context as to why we had to move forward with this revert?

[thienlnam]

#34253 (comment)

I told you here Ioni 😆
#34253 (comment)

[iwiznia]

Ohhh, still, leaving info on the PR is always useful.

Anyway, so can I just send this PR again as is or do we need to do something else?

[iwiznia]

ok PR sent

[quinthar]

Can we close this?

[iwiznia]

No, issues get closed automatically when the corresponding PR gets deployed and the PR above is not even merged.

[quinthar]

ah, what remains to be done, who is doing it, and when will it be done?

[iwiznia]

Seems the automation did not work since this was already deployed #35576 (comment) but issue was not closed