[HOLD for payment 2024-06-28] [$250] Timezone in the ND app is not updated after moving to another timezone location

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704159771205659

Action Performed:

1. In ND app timezone is set to Automatically determine the location
2. User moves from timezone A to timezone B
3. Check the timezone in ND in chrome web and in mobile and desktop time

Expected Result:

Timezone is updated in ND to B

Actual Result:

Timezone is not updated

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01059d3aa439712d2e
• Upwork Job ID: 1752475553672241152
• Last Price Increase: 2024-05-29
• Automatic offers:
• alitoshmatov | Reviewer | 102612346
• dominictb | Contributor | 102612348

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Not sure how to test this without but going to try with a VPN

[MitchExpensify]

I took a little trip to Frankfurt and hard refreshed while there but the timezone did not automatically update in NewDot

[MitchExpensify]

It didn't update after signing out and back in either

[MitchExpensify]

Lastly, I am not sure if this fits into any wave or VIP. What do you think about it being in #vip-vsb @quinthar?

[melvin-bot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Asking here https://expensify.slack.com/archives/C066HJM2CAZ/p1705179873734529

[melvin-bot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Checking in again on a home for this: https://expensify.slack.com/archives/C066HJM2CAZ/p1705530053332199?thread_ts=1705179873.734529&cid=C066HJM2CAZ

[melvin-bot]

@MitchExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MitchExpensify]

It does seem to update after a hard refresh every time for me, would you still consider it a bug if it updates upon refresh @quinthar?

[MitchExpensify]

Friendly bump on the above question @quinthar 👀

[melvin-bot]

@MitchExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: use polyfill instead of polyfill-force for @formatjs/intl-datetimeformat #43158

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

• $250 @alitoshmatov requires payment automatic offer (Reviewer)
• $250 @dominictb requires payment automatic offer (Contributor)

Thoughts on the BZ steps, @alitoshmatov ?

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: Add DateTimeFormat polyfills with timezone abbreviations #31074
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/31074/files#r1623639817
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• Determine if we should create a regression test for this bug.

Regression Test Proposal

Prerequisite: Automatically determine your location. is turned on in timezone section in ND

1. Go to profile > Timezone
2. In your devices native settings change your timezone
3. Make sure Timezone is updated to what you have changed to
   You may be required to go to different page of ND and coming back to Timezone page

Do we agree 👍 or 👎

[jasperhuangg]

Not overdue, BZ steps are moving along 👍

[jasperhuangg]

Ahhh melvin pls 😆

[situchan]

As @MitchExpensify is the issue owner, he's the only person who can remove Overdue by commenting.

[melvin-bot]

@jasperhuangg, @MitchExpensify, @alitoshmatov, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Paid and contract ended for @alitoshmatov

I need you to accept this offer to complete your payment @dominictb https://www.upwork.com/nx/wm/offer/102612348

[dominictb]

@MitchExpensify This issue was created from Jan 5, so as per the announcement the base price (if issue created before April 4) should remain as $500.

Could you help to update the offer accordingly? 🙇 🙇

[MitchExpensify]

I'll issue the additional payment as a bonus if you can accept the existing offer, thanks @dominictb

[dominictb]

@MitchExpensify UW offer accepted, thanks 🚀

[MitchExpensify]

Nice, paid and contract ended!