Tax - Selecting tax after refreshing tax rate redirects user to request page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32550

Action Performed:

Precondition:

• Tax is enabled on the Collect workspace on Old Dot of which user is a member

1. Go to workspace chat > Request money > Manual
2. Enter amount > Next
3. Click Show more > Tax
4. Refresh the page
5. Select a tax

Expected Result:

The tax is selected

Actual Result:

User is redirected to request money page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333447_1704482514323.20240106_031010.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MIAhmed]

@lanitochka17 it seems like entering the tax information is also part of payment request creation while the payment was still not created by the time refresh was clicked. Since it was not saved for the same reason it was again landing on the payment request creation after the refresh.
Is it Really an issue?

[melvin-bot]

📣 @MIAhmed! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect page opens on going back from tax page after refresh

What is the root cause of that problem?

We are providing the wrong fallback route for the tax pages. PR

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.js

Line 63 in f5a3c02

Navigation.goBack(ROUTES.MONEY_REQUEST_CONFIRMATION.getRoute(iouType, reportID));

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.js

Line 76 in f5a3c02

Navigation.goBack(ROUTES.MONEY_REQUEST_CONFIRMATION.getRoute(iouType, reportID));

What changes do you think we should make in order to solve the problem?

We need to consider backTo param from the route as a fallback route and we can remove other unneeded params. Also apply the same fix for the IOURequestStepTaxAmountPage.

Add backTo here.

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.js

Line 55 in f5a3c02

params: {iouType, reportID},

Provide below fallback route for navigation goBack.

Navigation.goBack(backTo || ROUTES.HOME);

[amyevans]

This is stemming from a new feature, which I'm not sure is intended to be complete at this stage or not (but I am guessing not). It's also a relative edge case. So I'm going to remove the deploy blocker label.

@MonilBhavsar @teneeto would y'all like to take this issue over since it's related to your feature build?

[teneeto]

Hi @amyevans I can look into this. cc @MonilBhavsar

[teneeto]

@amyevans kindly assign this to me. This is fixed in a follow-up Draft PR 33927

[MonilBhavsar]

@teneeto assigned you to the issue

[teneeto]

@MonilBhavsar @amyevans Opened a PR for this.

[MonilBhavsar]

PR is merged. We can close this once the PR is deployed to production

[melvin-bot]

This issue has not been updated in over 15 days. @amyevans, @teneeto eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[amyevans]

Whoops, PR deployed a while ago, closing now.