Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-22] [HOLD for payment 2024-01-18] IOU - App does not scroll down to show the latest message when editing expense request #34240

Closed
6 tasks done
kbecciv opened this issue Jan 10, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to workspace chat.
  2. Create a manual request.
  3. Open details page.
  4. Edit any field.

Expected Result:

The app scrolls down to show the latest message when editing expense request.

Actual Result:

The app does not scroll down to show the latest message when editing expense request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337769_1704898563167.bandicam_2024-01-10_19-07-03-098.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@0xmiros
Copy link
Contributor

0xmiros commented Jan 10, 2024

ok so issue created here. this came from #32098
cc: @perunt @roryabraham

@perunt
Copy link
Contributor

perunt commented Jan 10, 2024

Can confirm that bringing autoscrollToTopThreshold back is fixing that issue
#34244

@arosiclair
Copy link
Contributor

Alright assigning you guys to handle this

@arosiclair
Copy link
Contributor

confirm that bringing autoscrollToTopThreshold back is fixing that issue
#34244

Please link that PR to this issue!

Copy link

melvin-bot bot commented Jan 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@roryabraham
Copy link
Contributor

Should be fixed in #34244

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@roryabraham
Copy link
Contributor

This is checked off on the checklist. Going to close this out

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jan 11, 2024
@melvin-bot melvin-bot bot changed the title IOU - App does not scroll down to show the latest message when editing expense request [HOLD for payment 2024-01-18] IOU - App does not scroll down to show the latest message when editing expense request Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @perunt does not require payment (Contractor)
  • @0xmiroslav requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-18] IOU - App does not scroll down to show the latest message when editing expense request [HOLD for payment 2024-01-22] [HOLD for payment 2024-01-18] IOU - App does not scroll down to show the latest message when editing expense request Jan 15, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @perunt does not require payment (Contractor)
  • @0xmiroslav requires payment (Needs manual offer from BZ)

@situchan
Copy link
Contributor

@roryabraham can I get payment for PR review?

@roryabraham
Copy link
Contributor

Yes, it looks like we need to issue a $500 payment to @situchan tor a C+ review here.

@roryabraham roryabraham assigned situchan and unassigned perunt and 0xmiros Jan 29, 2024
@roryabraham roryabraham reopened this Jan 29, 2024
@roryabraham roryabraham added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 29, 2024
Copy link

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 29, 2024
@roryabraham
Copy link
Contributor

Payment is ready to issue immediately, thanks for commenting @situchan, apologies for missing this.

@melvin-bot melvin-bot bot added the Overdue label Feb 1, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@anmurali, @roryabraham, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 6, 2024

@anmurali, @roryabraham, @situchan Still overdue 6 days?! Let's take care of this!

@anmurali
Copy link

anmurali commented Feb 6, 2024

@situchan - Offer is here

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2024
@anmurali
Copy link

anmurali commented Feb 8, 2024

Paid!

@anmurali anmurali closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants