-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LHN - LHN becomes empty after setting preference to focus mode #34258
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @bondydaa ( |
It looks that there is no chat to be displayed in focus mode |
yeah if there are no unread chats then i don't think anything should be showing up in the LHN |
This only happens on an account without a concierge chat. Concierge chat should be shown by default |
what's the production behavior then? |
in the video the concierge chat is shown at the bottom of the LHN when the video starts, also if there isn't a chat with concierge then that's a different bug altogether since every account gets created with a chat with concierge on the back end. |
Hmm, you're right, I didn't notice that
The way I reproduce it is:
Because #focus will only load minimum chat that will be shown on the LHN and concierge is not included
Same empty LHN with my repro steps above |
okay discussed the bug here https://expensify.slack.com/archives/C049HHMV9SM/p1704906122169579 and sounds like yes we agree this is a bug. The LHN should should the last chat you opened if there are no other unread messages. |
I can confirm on web v1.4.24-0 doesn't do this and properly shows the last chat in opened in the LHN so seems like it might be something specific to mobile code. |
We've opened an internal fire room b/c others are reporting similar-ish behavior here even on |
There is a good chance this is fixed by a back end revert that we are going to deploy shortly. Once the deploy is done, I'll bump the issue and see about having it re-tested to confirm. |
@lanitochka17 can you retest this again and see if it's still reproducible? the backend deploy has finished and so it should be fixed 🙏 |
I am unable to reproduce on staging! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The LHN should show one chat which was previously open
Actual Result:
LHN becomes empty
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6337849_1704901732564.Screen_Recording_20240110_180206_Chrome.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: