Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - LHN becomes empty after setting preference to focus mode #34258

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 10, 2024 · 14 comments
Closed
1 of 6 tasks

LHN - LHN becomes empty after setting preference to focus mode #34258

lanitochka17 opened this issue Jan 10, 2024 · 14 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open a chat and go back to LHN
  2. Go to settings > Preferences > change priority mode to focus
  3. Go back and observe the LHN

Expected Result:

The LHN should show one chat which was previously open

Actual Result:

LHN becomes empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337849_1704901732564.Screen_Recording_20240110_180206_Chrome.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@s-alves10
Copy link
Contributor

It looks that there is no chat to be displayed in focus mode

@bondydaa
Copy link
Contributor

yeah if there are no unread chats then i don't think anything should be showing up in the LHN

@bernhardoj
Copy link
Contributor

This only happens on an account without a concierge chat. Concierge chat should be shown by default

@situchan
Copy link
Contributor

what's the production behavior then?

@bondydaa
Copy link
Contributor

This only happens on an account without a concierge chat. Concierge chat should be shown by default

in the video the concierge chat is shown at the bottom of the LHN when the video starts, also if there isn't a chat with concierge then that's a different bug altogether since every account gets created with a chat with concierge on the back end.

@bernhardoj
Copy link
Contributor

in the video the concierge chat is shown at the bottom of the LHN when the video starts

Hmm, you're right, I didn't notice that

also if there isn't a chat with concierge then that's a different bug altogether since every account gets created with a chat with concierge on the back end.

The way I reproduce it is:

  1. Set preference mode to #focus
  2. Log out and re login
  3. It will show empty LHN

Because #focus will only load minimum chat that will be shown on the LHN and concierge is not included

what's the production behavior then?

Same empty LHN with my repro steps above

@bondydaa
Copy link
Contributor

okay discussed the bug here https://expensify.slack.com/archives/C049HHMV9SM/p1704906122169579 and sounds like yes we agree this is a bug.

The LHN should should the last chat you opened if there are no other unread messages.

@bondydaa
Copy link
Contributor

I can confirm on web v1.4.24-0 doesn't do this and properly shows the last chat in opened in the LHN so seems like it might be something specific to mobile code.

@bondydaa
Copy link
Contributor

We've opened an internal fire room b/c others are reporting similar-ish behavior here even on 1.4.23-2 (desktop) where chats in the LHN are disappearing. Not even just in #focus mode either.

@bondydaa
Copy link
Contributor

There is a good chance this is fixed by a back end revert that we are going to deploy shortly.

Once the deploy is done, I'll bump the issue and see about having it re-tested to confirm.

@bondydaa
Copy link
Contributor

@lanitochka17 can you retest this again and see if it's still reproducible? the backend deploy has finished and so it should be fixed 🙏

@thienlnam
Copy link
Contributor

I am unable to reproduce on staging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants