Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - "Unexpected error.." message appears when employee click Submit #34259

Closed
6 tasks done
lanitochka17 opened this issue Jan 10, 2024 · 5 comments
Closed
6 tasks done
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33811

Action Performed:

  1. Log in to ND as the employee
  2. Go to the workspace chat > + > Request money
  3. Create a manual request
  4. Create Scan request
  5. Click on the expense preview
  6. Click Submit while scan is still in progress

Expected Result:

There should be no error message when user click Submit

Actual Result:

"Unexpected error Please try again later" message appears when employee click submit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337864_1704902677417.Recording__1740.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Jan 10, 2024

Umm.. This is expected. You can't submit request when scanning request is underway. For showing meaningful message, you need to configure BE to give correct message.

@NikkiWines
Copy link
Contributor

NikkiWines commented Jan 10, 2024

🤔 I don't even see the option to submit the request while it's still scanning (on dev or staging). But yes, we should handle any attempts to do that with a better error message.

image

@lanitochka17 are there more specific steps to be able to see the Submit button in this case?

@NikkiWines
Copy link
Contributor

Anyway, looking at the testing videos in #33811 it looks like this is actually the intended behavior and the testing steps are just unclear. Double checking against the issue that PR resolves we can see the accepted proposal shows this exact flow as it's reproduced here.

TLDR; expected behavior (as @shubham1206agra said), not a blocker. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants