Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - Double IOU are seen in IOU report screen #34260

Closed
3 of 6 tasks
kbecciv opened this issue Jan 10, 2024 · 31 comments
Closed
3 of 6 tasks

[$500] IOU - Double IOU are seen in IOU report screen #34260

kbecciv opened this issue Jan 10, 2024 · 31 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.24-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32698

Action Performed:

  1. Go Offline
  2. Add a money request in 1:1 DM chat Report
  3. Go to IOU details page and send a comment
  4. Delete the IOU from within the IOU details page
  5. Go back to IOU report page and add another IOU request
  6. Go to Parent chat report and go Online
  7. Wait until you are fully online and Click on the IOU preview component
  8. Scroll up (go back to parent chat report and go back in to IOU report if you don't see the bug at first)

Expected Result:

There should be only one IOU component

Actual Result:

Two IOU components are visible in IOU report page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337879_1704903475455.PR32698_-_bug_3.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013ced1698c9a376c1
  • Upwork Job ID: 1745119819895382016
  • Last Price Increase: 2024-01-31
  • Automatic offers:
    • hoangzinh | Reviewer | 28133177
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title IOU - Double IOU are seen in IOU report screen [$500] IOU - Double IOU are seen in IOU report screen Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013ced1698c9a376c1

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 12, 2024
@CortneyOfstad
Copy link
Contributor

Still waiting on proposals 👍

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
Copy link

melvin-bot bot commented Jan 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 17, 2024
@CortneyOfstad
Copy link
Contributor

Still waiting on proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 17, 2024
@CortneyOfstad
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
Copy link

melvin-bot bot commented Jan 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2024
@hoangzinh
Copy link
Contributor

Still waiting on proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 24, 2024
@CortneyOfstad
Copy link
Contributor

@hoangzinh @kbecciv can we confirm if the issue is still happening/reproduceable?

@hoangzinh
Copy link
Contributor

Screenshot 2024-01-30 at 22 43 27

I'm still able to reproduce in the latest main branch

Copy link

melvin-bot bot commented Jan 31, 2024

@hoangzinh @CortneyOfstad this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Jan 31, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@CortneyOfstad
Copy link
Contributor

Reached out to Call Stack to see if someone can take this one and get it over the finish line 👍

Asked in Slack here

@teneeto
Copy link
Contributor

teneeto commented Jan 31, 2024

Hi, I'm Eto from Callstack - expert contributor group - and I would like to look into this issue.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@CortneyOfstad
Copy link
Contributor

@teneeto any update on the PR? Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@teneeto
Copy link
Contributor

teneeto commented Feb 6, 2024

Hi @CortneyOfstad I'm working on a proposal, will come back here by tomorrow.

Copy link

melvin-bot bot commented Feb 7, 2024

@hoangzinh @CortneyOfstad @teneeto this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

@teneeto
Copy link
Contributor

teneeto commented Feb 8, 2024

Hi @hoangzinh, I'm able reproduce this and I'm sure I can find a trace to this issue. Couldn't complete my investigations - as i was focused on other reviews. I will continue today and let you know what my findings are. Apologies for delay, Thanks. cc @CortneyOfstad

@kameshwarnayak
Copy link
Contributor

@CortneyOfstad Is this still open for the external contributors to look into? I can try to find the root cause and give a proposal if it is open. This looks interesting

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@teneeto
Copy link
Contributor

teneeto commented Feb 12, 2024

Hi @kameshwarnayak I'm glad to know you're interested in this issue. I'm currently looking into it at the moment.

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@teneeto
Copy link
Contributor

teneeto commented Feb 12, 2024

@CortneyOfstad This issue seem to be somehow intermittent for some reasons i can't tell. I have been able to trace down specifically to where this issue is happening, but unfortunately i can't test further, I have only been able to reproduce it once and after a code update, I'm not able to reproduce this behaviour any longer. Can we confirm if this issue persists?

@kameshwarnayak
Copy link
Contributor

@teneeto Sure. No worries :)

@CortneyOfstad
Copy link
Contributor

@kbecciv can you confirm the issue is still happening?

@CortneyOfstad
Copy link
Contributor

Bump @kbecciv ^^^ Thanks!

@kbecciv
Copy link
Author

kbecciv commented Feb 14, 2024

Checking @CortneyOfstad

@kbecciv
Copy link
Author

kbecciv commented Feb 14, 2024

issue is no longer reproducible!

Screen_Recording_20240214_210856_Chrome.mp4

@CortneyOfstad
Copy link
Contributor

Thanks @kbecciv! Closing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants