Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU – The amount is not displayed when the scan of the PDF receipt is complete #34295

Closed
3 of 6 tasks
lanitochka17 opened this issue Jan 10, 2024 · 16 comments
Closed
3 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in as the WS employee
  3. Select the option to Request money > Scan receipt
  4. Select the option to upload a receipt
  5. Upload a PDF receipt file
  6. Click on Request
  7. Wait until the scan of the receipt is complete
  8. Once complete navigate to the request conversation

Expected Result:

The amount is updated and displayed

Actual Result:

The amount is not displayed when the scan of the PDF receipt is complete, red dot appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6338093_1704915385793.The_amount_is_not_displayed_when_the_scan_of_the_PDF_receipt.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 10, 2024

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

Do you have the PDF that was used? The video makes it seem like the smartscan was unable to find an amount in the receipt

@thienlnam thienlnam added Daily KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 11, 2024
@situchan
Copy link
Contributor

Do you have the PDF that was used? The video makes it seem like the smartscan was unable to find an amount in the receipt

@lanitochka17 please

@joelbettner
Copy link
Contributor

Just a heads up, this seems like it might be related to #34064.

@melvin-bot melvin-bot bot added the Overdue label Jan 15, 2024
@joelbettner
Copy link
Contributor

@lanitochka17 gentle bump.

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
@lanitochka17
Copy link
Author

ReceiptExample

Steps:

  1. Go to https://staging.new.expensify.com/
  2. Log in as the WS employee
  3. Create scan request
  4. Open IOU while the receipt is scanning
  5. Edit the missing fields Merchant and Amount
  6. Go back and reopen the IOU

@joelbettner
Copy link
Contributor

I was not able to re-create this. @lanitochka17 the title of the issue says a PDF receipt was scanned, but you've provided a .png image.

@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2024
@joelbettner
Copy link
Contributor

@lanitochka17 could you try to re-create it again? It is possible that this has already been fixed by some other PRs.

@lanitochka17
Copy link
Author

Issue is still reproducible on the latest build 1.4.28-0

bandicam.2024-01-19.16-21-25-192.mp4

PDF_receipt.pdf

@joelbettner
Copy link
Contributor

Thank you @lanitochka17!

@situchan the pdf has been provided in the comment above.

@joelbettner
Copy link
Contributor

@lanitochka17 I tried the steps on staging and I was not able to reproduce the issue.

  • I logged in as an employee on a workspace.
  • I uploaded the pdf as a scan for a money request.
  • I opened the money request while the pdf was scanning and changed the merchant and amount
  • I went back to the IOU report and things looked correct
image

@situchan
Copy link
Contributor

situchan commented Jan 19, 2024

Not able to reproduce red dot error

Screenshot 2024-01-20 at 2 03 48 AM Screenshot 2024-01-20 at 2 03 56 AM

@joelbettner
Copy link
Contributor

@lanitochka17 I'm still quite confused. I'm not able to reproduce this and neither is @situchan.

From the recent video you posted, it looks like the amount never got set during when it was scanning...is that correct? Then, in the video, I do not see you attempting to update the amount as per the reproduction instructions.

I think you may have just run into a smartscan that was incorrect, in which case the user would be able to update the amount?

@joelbettner
Copy link
Contributor

If I follow the instructions at the top in the original issue I get the following, which all looks good to me:

I smartscanned the pdf and let it complete:
image

After it completed smart scanning I opened the transation:
image

I edited the amount as per the instructions because the smartscanner could not determine which value should be used as the amount:
image

Everything saved correctly:
image

I don't think this is a bug. I think this is just a weird receipt where the amount that should be entered for the transaction is very unclear. When I look at it I cannot tell if the amount should be 9.99, -0.38, 0.38, or 0.00.

image

So, I think the smartscanner did the correct thing in this case and left the amount value to be determined by the user.

@joelbettner
Copy link
Contributor

I'm going to close this issue. Feel free to re-open if it is happening with many smartscans where the amount is obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

4 participants