Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Go to Expensify Classic icon is black instead of green #35468

Closed
1 of 6 tasks
kbecciv opened this issue Jan 31, 2024 · 11 comments
Closed
1 of 6 tasks

Android - Go to Expensify Classic icon is black instead of green #35468

kbecciv opened this issue Jan 31, 2024 · 11 comments
Assignees
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Jan 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.34-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to Settings.

Expected Result:

Go to Expensify Classic icon is green.

Actual Result:

Go to Expensify Classic icon is black instead of green.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 31, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@situchan
Copy link
Contributor

Seems like regression from #35097
cc: @barttom

@rlinoz
Copy link
Contributor

rlinoz commented Jan 31, 2024

@barttom do you think you can raise a quick PR for this one?

@barttom
Copy link
Contributor

barttom commented Jan 31, 2024

@barttom do you think you can raise a quick PR for this one?

@rlinoz I’ll try later today, at least tomorrow

@francoisl
Copy link
Contributor

This is currently blocking the deploy, so if we can't get a fix before tomorrow, let's revert the offending PR @rlinoz?

@rlinoz
Copy link
Contributor

rlinoz commented Jan 31, 2024

Yes, I will create the PR and request a CP, sorry for the delay.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 31, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jan 31, 2024

@rlinoz rlinoz removed the DeployBlockerCash This issue or pull request should block deployment label Jan 31, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jan 31, 2024

Removing deploy blocker label since revert was CP'd

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 1, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

This issue has not been updated in over 15 days. @rlinoz eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@rlinoz
Copy link
Contributor

rlinoz commented Feb 26, 2024

Closing this one in favor of #35018, as the fix proposal is in there and the PR is already in staging.

@rlinoz rlinoz closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants