Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave8] Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot #35516

Closed
3 of 6 tasks
kbecciv opened this issue Jan 31, 2024 · 32 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.34.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:
User is Employee of Collect workspace and

  1. Navigate to workspace chat as employee
  2. Click +> Request money> Manual
  3. As Admin navigate to Old dot and disable Tag 1
  4. As employee on click on Tag section and check the list

Expected Result:

Tag 1 should not be present in tags list

Actual Result:

Tag 1 should is present in tags list

Workaround:

Unknow

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362831_1706731891395.Recording__1985.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dedbcd7acaf45c5a
  • Upwork Job ID: 1758284653418659840
  • Last Price Increase: 2024-02-16
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Jan 31, 2024

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

@greg-schroeder greg-schroeder changed the title IOU - Disabled tag is displayed in tags list when create IOU Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot Jan 31, 2024
@greg-schroeder
Copy link
Contributor

This might be more Wave 8 as it's related to an admin action and workspace configuration... thoughts @zanyrenney?

@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@strepanier03
Copy link
Contributor

@zanyrenney - This is reproducible, do you agree including in Wave 8? Feel free to update the project and urgency label if you agree or let me know what you think otherwise.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 6, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@strepanier03
Copy link
Contributor

@zanyrenney - I'm going to add to Wave 8, let me know if you want it removed to it fits elsewhere.

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@strepanier03 strepanier03 changed the title Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot [Wave8] Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot Feb 12, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
@strepanier03
Copy link
Contributor

I'm going to assume this is an internal issue but could easily be wrong. Let me know if I should change this!

@melvin-bot melvin-bot bot removed the Overdue label Feb 16, 2024
@strepanier03 strepanier03 added the Internal Requires API changes or must be handled by Expensify staff label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01dedbcd7acaf45c5a

Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

@jjcoffee
Copy link
Contributor

Can't repro on v1.4.42-1 @kbecciv can you retest?

@kbecciv
Copy link
Author

kbecciv commented Feb 16, 2024

@jjcoffee Checking

@kbecciv
Copy link
Author

kbecciv commented Feb 16, 2024

Issue is still reproducible

Recording.2340.mp4

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

@strepanier03, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

All good Melvin.

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2024
@strepanier03 strepanier03 changed the title [HOLD- #35909] [Wave8] Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot [Wave8] Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot Mar 11, 2024
@strepanier03 strepanier03 added Daily KSv2 and removed Weekly KSv2 labels Mar 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@strepanier03
Copy link
Contributor

Asked for a retest here.

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@kavimuru
Copy link

@strepanier03 Issue is reproduced in real time. If the page is refreshed on employee side then issue is not reproduced.

Recording.2584.mp4
Recording.2581.mp4

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@strepanier03
Copy link
Contributor

Thank you Kavi, this is assigned to a project so we'll wait for it to be picked up.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 19, 2024
@strepanier03
Copy link
Contributor

Labeled ToDo, so likely to be a bit before it's picked up.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 25, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@strepanier03, @jjcoffee 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot removed the Daily KSv2 label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

This issue has not been updated in over 14 days. @strepanier03, @jjcoffee eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Apr 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2024
@strepanier03
Copy link
Contributor

Not set to a priority at this time but held for the future.

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@melvin-bot melvin-bot bot added the Overdue label May 2, 2024
@strepanier03
Copy link
Contributor

Waiting for prioritization.

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2024
@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@strepanier03
Copy link
Contributor

Waiting for prioritization still.

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@strepanier03
Copy link
Contributor

Hmmm, just noticed this is the only outstanding issue on Wave8, which isn't a project any longer.

I'm going to close this out and we can reopen if we decide to prioritize and pull it into a new project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants