Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for Payment April 2nd, 2024][Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category #35708

Closed
luacmartins opened this issue Feb 2, 2024 · 34 comments
Closed

[HOLD for Payment April 2nd, 2024][Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category #35708

luacmartins opened this issue Feb 2, 2024 · 34 comments
Assignees
@luacmartins @ArekChr @dylanexpensify @ishpaul777
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024 •
edited by dylanexpensify
Loading

Implement WorkspaceEditCategoryPage: full implementation, onyx action from the CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category
@luacmartins luacmartins added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Feb 2, 2024
@luacmartins luacmartins self-assigned this Feb 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@ArekChr can you please comment here so I can assign you to the issue?

@luacmartins luacmartins changed the title CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category [Simplified Collect] [Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category Feb 2, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category [Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category Feb 2, 2024
@ArekChr
Copy link
Contributor

ArekChr commented Feb 5, 2024

Sure, please assign me @luacmartins

@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2024
@dylanexpensify
Copy link
Contributor

Assigned!

@dylanexpensify
Copy link
Contributor

@ArekChr mind giving an update?

@ArekChr
Copy link
Contributor

ArekChr commented Feb 7, 2024

Hey @dylanexpensify work in progress! I will create a draft PR soon

@trjExpensify trjExpensify changed the title [Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category [Hold #35705][Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category Feb 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 13, 2024

@luacmartins, @ArekChr, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

@dylanexpensify
Copy link
Contributor

Nice! Any updates yet?

@dylanexpensify
Copy link
Contributor

same

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2024
@ArekChr
Copy link
Contributor

ArekChr commented Feb 14, 2024

Hey @dylanexpensify, I've been busy implementing the main page for categories. Today, I almost finished the work there and started working on the category settings

@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 19, 2024

@luacmartins, @ArekChr, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

@luacmartins
Copy link
Contributor Author

On hold

@abekkala abekkala mentioned this issue Feb 28, 2024
Closed
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 29, 2024
@ArekChr ArekChr mentioned this issue Feb 29, 2024
Closed
@ArekChr
Copy link
Contributor

ArekChr commented Feb 29, 2024

PR is ready for review

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@iwiznia
Copy link
Contributor

iwiznia commented Mar 1, 2024

PR has wrong copy https://expensify.slack.com/archives/C01GTK53T8Q/p1709305812229179?thread_ts=1709215749.926399&cid=C01GTK53T8Q

@luacmartins
Copy link
Contributor Author

Yes, I created this issue to fix the copy - #37614

@ishpaul777
Copy link
Contributor

@luacmartins Can you please assign me here.. I reviewed the PR

@trjExpensify
Copy link
Contributor

Done!

@ishpaul777
Copy link
Contributor

Thank you!

@trjExpensify trjExpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 13, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 19, 2024
@dylanexpensify
Copy link
Contributor

Payment summary:

@dylanexpensify
Copy link
Contributor

@ishpaul777 please apply here!

@ishpaul777
Copy link
Contributor

@dylanexpensify I reached out to you on slack can you please check

@dylanexpensify dylanexpensify changed the title [Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category [HOLD for Payment April 2nd, 2024][Simplified Collect][Categories] CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category Mar 26, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Apr 4, 2024 •
edited
Loading

hii @dylanexpensify Thanks for holding! Can you please send in the offer https://www.upwork.com/freelancers/~01f4fddf5caa8bfc3a

@luacmartins luacmartins removed the Reviewing Has a PR in review label Apr 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@dylanexpensify
Copy link
Contributor

@ishpaul777 sent invite to apply!

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@ishpaul777
Copy link
Contributor

Thanks! Applied 🙂

@dylanexpensify
Copy link
Contributor

Offer sent @ishpaul777!!

@ishpaul777
Copy link
Contributor

Accepted 🫡

@dylanexpensify
Copy link
Contributor

Done! Thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@ArekChr ArekChr

@dylanexpensify dylanexpensify

@ishpaul777 ishpaul777

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
[#whatsnext] #wave-collect
Archived in project
[#whatsnext] Wave 08 - Collect Plan Admins
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Milestone
No milestone
Development

No branches or pull requests
6 participants
@iwiznia @trjExpensify @luacmartins @ArekChr @dylanexpensify @ishpaul777