Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App 35455][$500] Send money - Not here page opens when opening Description in Send money flow #36342

Closed
6 tasks done
lanitochka17 opened this issue Feb 12, 2024 · 17 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33601

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Send money
  3. Enter amount and select participant
  4. On confirmation page, click Description

Expected Result:

Description editor opens without issue

Actual Result:

Not here page shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376647_1707748776886.bandicam_2024-02-12_22-22-11-178.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0169a121d63defc5fe
  • Upwork Job ID: 1757179215235969024
  • Last Price Increase: 2024-02-19
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-bills
CC @davidcardoza

@mananjadhav
Copy link
Collaborator

@lanitochka17 I am able to reproduce this on production, but the GH states Reproducible in production?: N.

Screenshot 2024-02-12 at 9 06 41 PM

@lanitochka17
Copy link
Author

sorry for confusion I can reproduce on Production too

Recording.1244.mp4

@srikarparsi
Copy link
Contributor

Sounds good, removing the deploy blocker label from this issue

@srikarparsi srikarparsi added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 12, 2024
@melvin-bot melvin-bot bot changed the title Send money - Not here page opens when opening Description in Send money flow [$500] Send money - Not here page opens when opening Description in Send money flow Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0169a121d63defc5fe

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@zoilorys
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.

During send money flow description is not opening.

What is the root cause of that problem?

After looking into the implementation I noticed that there is actually no description step for creating a send request. The only implementation I could find is only for edit transaction flow. There is even no description route defined for send/new flow and it is hardcoded to navigate to description step in edit mode when clicking Description.

What changes do you think we should make in order to solve the problem?

In order to fix this, we should add new send/new/description/:reportID? route (similar to already existing send/new/amount/:reportID?), and update IOURequestStepDescription component to support create scenario.

What alternative solutions did you explore? (Optional)

@allgandalf
Copy link
Contributor

Can't be 100% sure, but isn't this a regression from #35137?

@mananjadhav
Copy link
Collaborator

Looks like it, and @DylanDylann is the original author as well as C+ here, so guessing they'll be able to confirm it.

@DylanDylann
Copy link
Contributor

This PR (It's about to be merged) will be resolve this issue

Copy link

melvin-bot bot commented Feb 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@srikarparsi srikarparsi changed the title [$500] Send money - Not here page opens when opening Description in Send money flow [HOLD https://github.com/Expensify/App/pull/35455][$500] Send money - Not here page opens when opening Description in Send money flow Feb 20, 2024
@srikarparsi srikarparsi changed the title [HOLD https://github.com/Expensify/App/pull/35455][$500] Send money - Not here page opens when opening Description in Send money flow [HOLD App 35455][$500] Send money - Not here page opens when opening Description in Send money flow Feb 20, 2024
@srikarparsi srikarparsi added Weekly KSv2 and removed Daily KSv2 labels Feb 20, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2024
@srikarparsi
Copy link
Contributor

On hold for this PR

@melvin-bot melvin-bot bot added the Overdue label Feb 28, 2024
@DylanDylann
Copy link
Contributor

still on hold

@srikarparsi
Copy link
Contributor

Still on hold, asked for an ETA on the PR

@melvin-bot melvin-bot bot removed the Overdue label Mar 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@srikarparsi
Copy link
Contributor

PR hit staging, no longer reproducible. Going to close this out.

@melvin-bot melvin-bot bot removed the Overdue label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants