[HOLD for payment 2024-02-26] [$500] Routing number field is not auto focused.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. go to workspace setting
2. Click on connect manually

Expected Result:

Routing number is autofocussed

Actual Result:

Not autofocussed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/61cc5edf-5053-40a2-b842-d4f9bc9309da

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2f2f4d15d74aa10
• Upwork Job ID: 1757551499003891712
• Last Price Increase: 2024-02-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2f2f4d15d74aa10

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Routing number field is not auto focused

What is the root cause of that problem?

App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx

Lines 71 to 82 in 023d62c

	<InputWrapper
	InputComponent={TextInput}
	inputID={BANK_INFO_STEP_KEYS.ROUTING_NUMBER}
	label={translate('bankAccount.routingNumber')}
	aria-label={translate('bankAccount.routingNumber')}
	role={CONST.ROLE.PRESENTATION}
	defaultValue={defaultValues[BANK_INFO_STEP_KEYS.ROUTING_NUMBER]}
	inputMode={CONST.INPUT_MODE.NUMERIC}
	disabled={shouldDisableInputs}
	shouldSaveDraft
	shouldUseDefaultValue={shouldDisableInputs}
	/>

No autofocus logic

Before VBBA refactor:

                    autoFocus
                    shouldDelayFocus={shouldDelayFocus}

these props were passed

What changes do you think we should make in order to solve the problem?

add them back

Important: we should add shouldDelayFocus prop as well for platform consistency. Without this, autofocus doesn't work in android.

shouldDelayFocus is imported from @libs/shouldDelayFocus

[mountiny]

I think this is not a blocker, @MrMuzyk @barttom can address this as a follow up to the PR @akinwale @shubham1206agra

[mountiny]

PR was CPed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: followup fixes for vbba refactor #36472

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: