Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] iOS - Notifications- User missing from chat Notification doesn’t mention the name or username #36494

Closed
1 of 6 tasks
kbecciv opened this issue Feb 14, 2024 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Feb 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.41-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Have notifications enabled and Go to any group chat
  2. Mention a user not in the chat and quickly background the app

Expected Result:

The notification mentions the name or username of the missing from the chat user

Actual Result:

The notification has a space instead of the name or username of the user that is missing from the chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379279_1707912848657.RPReplay_Final1707856366.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170deaa1d4d28d0fb
  • Upwork Job ID: 1757778526368702464
  • Last Price Increase: 2024-02-14
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Feb 14, 2024

We think that this bug might be related #vip-vsb
CC @quinthar

@danieldoglas
Copy link
Contributor

@kbecciv can you post the production video as well?

@kbecciv
Copy link
Author

kbecciv commented Feb 14, 2024

@danieldoglas Requesting production video!

@kbecciv
Copy link
Author

kbecciv commented Feb 14, 2024

@danieldoglas My apologies, just confirmed that the issue is reproducible on production! Changing the labels

@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 14, 2024
@melvin-bot melvin-bot bot changed the title iOS - Notifications- User missing from chat Notification doesn’t mention the name or username [$500] iOS - Notifications- User missing from chat Notification doesn’t mention the name or username Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0170deaa1d4d28d0fb

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 14, 2024
@danieldoglas danieldoglas removed their assignment Feb 14, 2024
@danieldoglas
Copy link
Contributor

Thanks! I'm unassigning myself, but I agree with you this should be part of vip-vsb, and it's probably internal

@danieldoglas danieldoglas added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Feb 15, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

@danieldoglas danieldoglas removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 15, 2024
@danieldoglas
Copy link
Contributor

I'll actually close this in favor of #36086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants