[Regression - HOLD on #39078 [HOLD for payment 2024-04-03] HIGH: [Video] [$500] iOS Safari - Video file preview not displayed after selecting video from device gallery

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com & log in
2. Go to 1:1 DM >> tap on + icon in composer field >> select Add atttachment option
3. Select video from photo library

Expected Result:

Video file preview should be displayed after selecting video from gallery

Actual Result:

Video file preview not displayed after selecting video from device gallery. Blank space is seen with only the video controls

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385229_1708394983543.RPReplay_Final1708389270.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cbcb9b31f838ae06
• Upwork Job ID: 1759795434302009344
• Last Price Increase: 2024-03-05

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cbcb9b31f838ae06

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

We think this bug might be related to #vip-vsb
cc @quinthar

[MonilBhavsar]

Not a blocker as it is minor issue on iOS Safari.
The PR for video player was merged yesterday #30829

[MonilBhavsar]

Commented on main PR #30829 (comment)

[stephanieelliott]

Thanks @MonilBhavsar! Reposting case it was missed on the PR: @akinwale @kosmydel @kowczarz, tagging you as this is related to the video player -- are any of you interested in picking this one up?

[MonilBhavsar]

No response yet. Awaiting proposals

[quinthar]

Can we close this?

[stephanieelliott]

Not yet! This PR is on staging -- once it hits prod and the 7 day regression period passes, it will be ready for payment and can be closed.

PR we're following is here: #38302

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.56-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix video file preview not displaying after selecting video from device gallery #38302

If no regressions arise, payment will be issued on 2024-04-03. 🎊

For reference, here are some details about the assignees on this issue:

• @Skalakid does not require payment (Contractor)
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[paultsimura]

Hi folks, I know it's out of the regression period now, but I've just found this GH. There was a regression reported a week ago.
The PR here didn't solve the issue correctly – on the physical iOS devices, the preview is now endlessly loading (appending #t=0.001 causes a WebKitBlobResource error on Webkit browsers).

@Skalakid could you take a look, please?

[stephanieelliott]

Thanks @paultsimura! Putting this on another hold for #39078 since it was opened during the regression period, we'll start the 7 day regression hold again once that PR is merged.

@Skalakid can you take a look at #39078?

[Skalakid]

Hi @stephanieelliott @paultsimura, I will take a look right now 😄

[paultsimura]

Thank you @Skalakid, there is one proposal, I wonder if you would consider it a possible solution 🤔

[Skalakid]

@paultsimura I commented under the issue. I think it's a good proposal and we can proceed with that. I also suggested one enhancement

[stephanieelliott]

Still held on #39078, discussion is going on there.

[stephanieelliott]

Still held on #39078

[stephanieelliott]

Still held on #39078. Last remaining task is to issue payment -- once 39078 is on prod and past the 7-day regression period, we will pay this issue out.

[MonilBhavsar]

I see other issue is being fixed by another contributor. Can we consider this as a regression and issue payment?

[stephanieelliott]

Thanks @MonilBhavsar, I think that's a good plan -- let's treat this as a regression and pay this one out.

Summarizing payment on this issue:

• Contributor: @Skalakid, no payment due (SWM)
• Contributor+: @c3024 $250 ($500 * 50% regression penalty) PAID via Upwork

Upwork job is here: https://www.upwork.com/jobs/~015b429315b92a65f2

[c3024]

@stephanieelliott accepted, thanks.

[stephanieelliott]

Thanks @c3024, all paid!