Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [MEDIUM] Tags: Unable to unselect or select a different tag after the request is created #36860

Closed
6 tasks done
izarutskaya opened this issue Feb 20, 2024 · 15 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #35541

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has categories and tags.
  1. Go to staging.new.expensify.com.
  2. Go to workspace chat.
  3. Create a manual request with tag.
  4. Go to request details page.
  5. Click Tag.
  6. Select a different tag.

Expected Result:

User should be able to unselect or select a different tag.

Actual Result:

Nothing happens when selecting a different tag. User is unable to change the tag after the request is created. The same goes for Category.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6385316_1708403351019.bandicam_2024-02-20_08-56-26-399.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015553cb48198a3559
  • Upwork Job ID: 1759890239807922176
  • Last Price Increase: 2024-02-20
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 20, 2024
@melvin-bot melvin-bot bot changed the title Tag - Unable to unselect or select a different tag after the request is created [$500] Tag - Unable to unselect or select a different tag after the request is created Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015553cb48198a3559

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

@paultsimura
Copy link
Contributor

Same root cause as here – it's caused by #35880

@shubham1206agra
Copy link
Contributor

@Santhosh-Sellavel is OOO.
So I will be helping out if needed here.

@kadiealexander
Copy link
Contributor

@mountiny @Pujan92 could you please take a look and see if your PR here will resolve this issue as well?

@mountiny
Copy link
Contributor

@kadiealexander he PR got Cped to staging so if you can repro in 1.4.43-5 its not solved

@shubham1206agra
Copy link
Contributor

@dukenv0307 Can you please look into this?

@dukenv0307
Copy link
Contributor

This bug isn't related to my PR now, has another bug with SectionList

Screenshot 2024-02-22 at 11 32 18

@shubham1206agra
Copy link
Contributor

@dukenv0307 Can you point out the PR and maybe a proposal to resolve this?

@dukenv0307
Copy link
Contributor

@shubham1206agra Sorry I posted the image for another bug with category.

I think this is fixed in this #36857 (comment) now. Can you please double check.

@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@greg-schroeder greg-schroeder changed the title [$500] Tag - Unable to unselect or select a different tag after the request is created [$500] [MEDIUM] Tag - Unable to unselect or select a different tag after the request is created Feb 23, 2024
@greg-schroeder greg-schroeder changed the title [$500] [MEDIUM] Tag - Unable to unselect or select a different tag after the request is created [$500] [MEDIUM] Tags: Unable to unselect or select a different tag after the request is created Feb 23, 2024
@kadiealexander
Copy link
Contributor

Not reproducible anymore:

image

Please reopen if it comes back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Development

No branches or pull requests

8 participants