[HOLD for payment 2024-04-03][$250] Chat - Missing Tooltip for Video Expand Button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Navigate to the conversion section
2, Add a video. The expand button appears alongside the video

Expected Result:

The expand button for videos should display a tooltip

Actual Result:

The expand button for videos does not display a tooltip

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385596_1708427639159.Screen_Recording_2024-02-19_at_10.59.45_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e702a28b240448c2
• Upwork Job ID: 1759949924144463872
• Last Price Increase: 2024-02-20
• Automatic offers:
• ntdiary | Reviewer | 0
• neonbhai | Contributor | 0

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e702a28b240448c2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[MahmudjonToraqulov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Missing Tooltip for Video Expand Button

What is the root cause of that problem?

We are missing the logic for showing a tooltip.

What changes do you think we should make in order to solve the problem?

We should wrap the icon here with Tooltip:

App/src/components/VideoPlayerPreview/index.js

Line 84 in a21cfbc

<IconButton

 <Tooltip text={translate('videoPlayer.expand')}>
 ...
 </Tooltip>

What alternative solutions did you explore? (Optional)

N/A

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Missing Tooltip for Video Expand Button

What is the root cause of that problem?

We have the Tooltip component outside the Hoverable Component here

This is the reason none of the tooltips are showing.

What changes do you think we should make in order to solve the problem?

We should move the Tooltip component inside the Hoverable component.

        <Hoverable>
            {(isHovered) => (
                <Tooltip
                    text={tooltipText}
                    shouldForceRenderingBelow={shouldForceRenderingTooltipBelow}
                >
                   ...
                </Tooltip>
              )}
        </Hoverable>

Result

This works perfectly:

Screen.Recording.2024-02-20.at.8.33.27.PM.mov

[arosiclair]

Looks like this IconButton is only used in the video player. Which is a bit confusing since there is another IconButton we use elsewhere, but that is a separate problem.

Since it's only for the video player I'm removing the blocker label. I'm also lowering the bounty to $250 since it is so simple.

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @ntdiary is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @ntdiary is eligible for the Internal assigner, not assigning anyone new.

[muttmuure]

Seems like LOW #vip-vsb

[arosiclair]

PR is on staging

[arosiclair]

PR hit prod on 2024-03-27

[arosiclair]

Couple more days until payment

[arosiclair]

Ready for payment @muttmuure

[muttmuure]

@ntdiary - $250 C+
@neonbhai - $250 C

[muttmuure]

@neonbhai paid, just waiting for @ntdiary to accept offer

[ntdiary]

@neonbhai paid, just waiting for @ntdiary to accept offer

@muttmuure, Thank you! Accepted it. 😄

[arosiclair]

Sounds like this is done ^

[ntdiary]

Hi, @muttmuure, I just noticed that this issue hasn't been paid yet.
Since I've switched to NewDot for payments and no longer use upwork. Can I request payment through NewDot? 😂

[ntdiary]

Hi, @muttmuure, I just noticed that this issue hasn't been paid yet. Since I've switched to NewDot for payments and no longer use upwork. Can I request payment through NewDot? 😂

Hi, @arosiclair, can you please reopen this issue so we can process the payment? 😄

cc @muttmuure

[mallenexpensify]

@ntdiary can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021836106341219430298

Your assigned date on this issue was a handful of days before your eligibility date

[ntdiary]

@mallenexpensify, Thank you! I have accepted the new job, and ended the previous contract. 😄

[muttmuure]

Paid - sorry for the oversight!