[$500] [MEDIUM] Scan Receipt - After edit a request while scanning, red dot disappears, scanning resumes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4327869
Email or phone of affected tester (no customers): stela.utest+29@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: There is workspace set up with 1 employee

1. Log in in the app as employee
2. Start the request money flow > "Scan" receipt as the employee
3. Upload a blurry receipt
4. Complete the money request flow
5. While the receipt is scanning - navigate to the request conversation
6. Click on the three dot overflow menu
7. Manually edit the merchant field
8. Leave the amount field showing an error
9. Navigate to the report conversation

Expected Result:

“Scan in progress” message is no longer displayed, a red dot appears in the preview, in the LHN, the workspace chat has a red dot in LHN

Actual Result:

After edit a request while the receipt is scanning, when navigating back to the workspace chat, the red dot disappears and scanning resumes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385924_1708448581885.keepsscanning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197730d9217c1aabc
• Upwork Job ID: 1759995216592060416
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0197730d9217c1aabc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

Bug6385924_1708448581868.prod.mp4

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[hayata-suenaga]

asking here
and here

[hayata-suenaga]

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 87 in ea0c07b

const isScanning = hasReceipt && TransactionUtils.isReceiptBeingScanned(transaction);

App/src/libs/TransactionUtils.ts

Line 439 in ea0c07b

function isReceiptBeingScanned(transaction: OnyxEntry<Transaction>): boolean {

[hayata-suenaga]

For the deployer:

I'm having a little bit of trouble figuring out the root cause of this regression. I'm asking for help in this thread.

[hayata-suenaga]

we can figure this out with contributors first to make sure that the error is coming from the backend

and then we can have wider discussion on what has recently been changed. I already brought the discussion to the Wave 6 Slack channel that is handling the Smart Scan.

By the way, this regression doesn't prevent the user from using the app. I'll remove the deploy blocker and change the priority to daily 🙇

[hayata-suenaga]

bumping in the slack

[jacobkim9881]

I can not reproduce it.

[hayata-suenaga]

requested the QA team to retest

[kbecciv]

Issue is no longer reproducible

github.mp4

[hayata-suenaga]

The QA team confirmed that the issue is no longer reproducible. Closing this issue 🙇