Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - There is no violation in the IOU details #36951

Closed
6 tasks done
lanitochka17 opened this issue Feb 20, 2024 · 10 comments
Closed
6 tasks done

[$500] IOU - There is no violation in the IOU details #36951

lanitochka17 opened this issue Feb 20, 2024 · 10 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34983

Action Performed:

Preconditions: Create a collect policy in OD. Enable the workspace chat. Enable "Must use tags" and "Multi level tags". Import the attached csv. Invite a member

  1. Log in with the member
  2. Open the workspace chat
  3. Create a manual IOU without using any of the tags
  4. Open the IOU details

Expected Result:

There should be only 1 "Required" text as you only have to use one tag
You should be getting a violation

Actual Result:

All of the multi level tags have the "Required" text next to them
There is no violation in the IOU details if you open it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ae765859-1d56-4e23-b054-71c1f9ff3bd9

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013c63e2b36821bb55
  • Upwork Job ID: 1760050849869365248
  • Last Price Increase: 2024-02-20
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 20, 2024
@melvin-bot melvin-bot bot changed the title IOU - There is no violation in the IOU details [$500] IOU - There is no violation in the IOU details Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013c63e2b36821bb55

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 20, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@wildan-m
Copy link
Contributor

Import the attached csv.

Which one?

@wildan-m
Copy link
Contributor

The problem is not reproducible; also, the "must use tags" option disappears when we enable multiple tags and refresh the page.
image

@chiragsalian
Copy link
Contributor

@lanitochka17, can you retest and confirm if the issue still persists?

@chiragsalian
Copy link
Contributor

Import the attached csv.

Which one?

I think its the one linked in this

Issue found when executing PR #34983

So this one,

@lanitochka17
Copy link
Author

Issue is not reproduced in the latest build 1.4.43-12

bandicam.2024-02-22.18-41-03-289.mp4

@chiragsalian
Copy link
Contributor

Cool, closing this issue since its not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants