Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-19] [P2P Distance] Enable split distance requests #36967

Closed
neil-marcellini opened this issue Feb 20, 2024 · 46 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Feb 20, 2024

Enable split distance requests following this plan

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017fd731ba8df719c5
  • Upwork Job ID: 1760074110878371840
  • Last Price Increase: 2024-02-20
@neil-marcellini neil-marcellini added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017fd731ba8df719c5

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

Copy link

melvin-bot bot commented Feb 26, 2024

@jjcoffee Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 28, 2024

@jjcoffee Still overdue 6 days?! Let's take care of this!

@jjcoffee
Copy link
Contributor

Chill, Melv ✌️

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

@jjcoffee Huh... This is 4 days overdue. Who can take care of this?

@neil-marcellini
Copy link
Contributor Author

I'm starting on this now. I will split up the plan into multiple PRs to keep each one small and focused. I will start with moving split participant normalization to Auth.

Actually, now that I look more closely, it makes sense to move the creation of an individual payer account to Auth first. Then we can re-use that Auth function to create all split accounts as needed. Therefore I'll HOLD this issue on the issue to implement that part [P2P Distance] Move creating the payer account for money requests from Web-E to Auth

@neil-marcellini neil-marcellini changed the title [P2P Distance] Enable split distance requests [HOLD 37061][P2P Distance] Enable split distance requests Mar 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 8, 2024
@neil-marcellini
Copy link
Contributor Author

On hold for a bit, moving to weekly

@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels Mar 11, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 19, 2024
@neil-marcellini
Copy link
Contributor Author

On hold

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@neil-marcellini
Copy link
Contributor Author

still holding

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 10, 2024
@neil-marcellini
Copy link
Contributor Author

I got all the PRs up for review. 🎉 It was a lot of work and there will be some more to do 😅
[Auth] [HOLD Web-E 42700] Enable distance splits
[Web-Expensify] [HOLD Auth 10851] Enable splits for distance expenses
[App] [HOLD Web-E 41977] Enable distance splits

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

This issue has not been updated in over 15 days. @neil-marcellini eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Aug 8, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Aug 12, 2024
@melvin-bot melvin-bot bot changed the title [P2P Distance] Enable split distance requests [HOLD for payment 2024-08-19] [P2P Distance] Enable split distance requests Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-19. 🎊

@neil-marcellini neil-marcellini added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 15, 2024
@neil-marcellini
Copy link
Contributor Author

Head's up, I'll be working 50% for the rest of this week and next 🌲

Copy link

melvin-bot bot commented Aug 15, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 15, 2024
@neil-marcellini
Copy link
Contributor Author

@twisterdotcom would you please handle payment for the C+ @mananjadhav

@twisterdotcom
Copy link
Contributor

@neil-marcellini what are we pricing this at? Normal $250?

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 labels Aug 18, 2024
@twisterdotcom
Copy link
Contributor

Going to go with $250 as normal here.

Payment Summary:

@JmillsExpensify
Copy link

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

5 participants