[$500] Hold Request - Submitting report with expenses that on hold returns unexpected error

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #33897

Version Number: 1.4.43-6
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition: create a workspace, and invite an employee and approver

1. Go to https://staging.new.expensify.com/

2. Log in as an employee

3. Navigate to a workspace chat

4. Create a manual request

5. Navigate to the expense detail page

6. Click on 3 dots > Hold request

7. Enter a reason and click on Hold request

8. Return to the expense report and submit the report

Expected Result:

The report is submitted and the system message is displayed

Actual Result:

The error message "Unexpected error, please try again later" is shown. After refreshing the page, the system message that the report was submitted is displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6386873_1708521501608.Recording__223.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ff1a69fd67e7b5ae
• Upwork Job ID: 1760296204787605504
• Last Price Increase: 2024-02-21

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ff1a69fd67e7b5ae

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[amyevans]

I can repro on the latest main Auth/Web/App locally, this is the SubmitReport response I receive:

{
    "jsonCode": 666,
    "title": "Cannot complete action",
    "message": "You do not have the permission to do the requested action.",
    "requestID": "pxZ0B3",
    "onyxData": []
}

I tried searching for logs from the QA tester to confirm it was the same error but can't find them 🤔 (searched with applausetester+0219pm1a@applause.expensifail.com / reportID 4675844924345473).

Since it's a backend error it likely shouldn't block App deploy, but I'm also not entirely sure of expected behavior so perhaps this action shouldn't be allowed in the first place.

cc @robertjchen

[robertjchen]

Hm, not a Deploy Blocker per se, since we're working on the approval/payment flow: https://expensify.slack.com/archives/C02NZ2HGJAZ/p1708478069824719

That said, does submit still break if the request is NOT on/removed from hold? 🤔

[mallenexpensify]

@robertjchen @amyevans should this be internal or external? Bumped back to Daily since it's a bug we want to fix. Adding to  #wave-collect too.

[robertjchen]

Internal- we will revisit after Partial Pay/Approve is out since it relates to that flow.

[robertjchen]

Same, holding till Partial Pay/Approve goes out

[mallenexpensify]

Bobby Bottles, is there a link for Partial Pay/Approve ?

[robertjchen]

yep! https://github.com/Expensify/Expensify/issues/378314

Seeing that it has gone out, let's retest this and see if it's still happening 👍

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mallenexpensify]

Tried to repro but not seeing HOLD option in upper tight when I click the three stacked dots

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[mallenexpensify]

@allroundexperts can you reproduce? If so, can you provide some deets, especially regarding how to put an expense on hold? If you're unable to repro, I'll close. Thx

[allroundexperts]

I do see the hold option. Make sure that you have multiple manual requests in a IOU report and then open any of the request. Clicking on the three dots in the header does show up the hold option. However, after pressing it and trying to submit the report, I can not reproduce the error mentioned in the issue description.

[allroundexperts]

Ref:

Screen.Recording.2024-05-27.at.1.10.59.AM.mov

[mallenexpensify]

Thanks @allroundexperts , following your steps I was able to use Hold. Was also unable to reproduce, so closing.