[$500] IOU - Message doesn't contain description when Copy to clipboard on money request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36993
Issue reported by: Applause - Internal eam

Action Performed:

1. Create a workspace and invite some users
2. As employee, create a money request with description in the workspace chat
3. As admin, paid this request
4. As employee hover or long press on money request preview > Copy to clipboard
5. Paste the message to composer

Expected Result:

Pasted message should contains the description

Actual Result:

Pasted message doesn't contain description when Copy to clipboard on money request preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394459_1709058859174.Recording__2367.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e3619582ba70c09
• Upwork Job ID: 1762552015212392448
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e3619582ba70c09

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paid Message doesn't contain description when Copy to clipboard on money request

What is the root cause of that problem?

when the request is settled we dont copy the description as we do in other cases here

App/src/libs/ReportUtils.ts

Lines 4746 to 4749 in f1562e7

	return Localize.translateLocal(translationKey, {
	formattedAmount,
	comment: transactionDetails?.comment ?? '',
	});

App/src/libs/ReportUtils.ts

Lines 4734 to 4744 in f1562e7

	const isApproved = isReportApproved(iouReport);
	if (isRequestSettled) {
	return Localize.translateLocal('iou.payerSettled', {
	amount: formattedAmount,
	});
	}
	if (isApproved) {
	return Localize.translateLocal('iou.approvedAmount', {
	amount: formattedAmount,
	});
	}

What changes do you think we should make in order to solve the problem?

we need to add the comment to the iou.payerSettled and iou.approvedAmount to be similar to this

App/src/languages/en.ts

Line 618 in 5c19e7f

requestedAmount: ({formattedAmount, comment}: RequestedAmountMessageParams) => `requested ${formattedAmount}${comment ? ` for ${comment}` : ''}`,

to acheive that we need to modify the code above to:

    if (isRequestSettled) {
        return Localize.translateLocal('iou.payerSettled', {
            amount: formattedAmount,
            comment: transactionDetails?.comment ?? '',
        });
    }
    if (isApproved) {
        return Localize.translateLocal('iou.approvedAmount', {
            amount: formattedAmount,
            comment: transactionDetails?.comment ?? '',
        });
    }

then modify these translations to

        payerSettled: ({amount, comment}: PayerSettledParams) => `paid ${amount} for ${comment}`,
        approvedAmount: ({amount, comment}: ApprovedAmountParams) => `approved ${amount} for ${comment}`,

and of course we need to modify their ts types.

we can also do the same here

[AndrewGable]

@dukenv0307 @DylanDylann @srikarparsi - Is this a regression from #36993?

[DylanDylann]

I will check today

[DylanDylann]

@AndrewGable I don't think this is regression from #36993
cc @dukenv0307

[DylanDylann]

IMO, this is not a bug. Let's see this case:

Screen.Recording.2024-02-28.at.12.30.41.mov

We have 2 requests with different descriptions. Then admin pays both requests. If we want to display a description in the paid message, which description should be displayed

[dukenv0307]

I tested by revert #36993 and the result is the same.

[melvin-bot]

@AndrewGable, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[AndrewGable]

@isabelastisser - Can you confirm this is not a bug as proposed by @DylanDylann? I agree with them

[isabelastisser]

I agree this is not a bug. Closing!