[No payment] Chat-URL link shown in preview but turned to text after sending message.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.45
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

1. Launch app
2. Tap on a report
3. Enter J.com in compose box and note URL link is shown
4. Send the message

Expected Result:

URL link shown in preview and same link format must be shown after sending message.

Actual Result:

URL link shown in preview but turned to text after sending message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6396611_1709183463397.az_recorder_20240229_074258.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb

@nkuoch I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[bernhardoj]

The parsing differences are caused by different versions of expensify-common used by react-native-live-markdown and App. (I think we should use peerDependencies)

The App includes this latest commit which makes a single character domain (e.g. j.com) not recognized as a link.

[youssef-lr]

Thanks @bernhardoj. cc @aswin-s this is coming from your PR

[aswin-s]

Checking.

Meanwhile the fix should be raised in expensify-commons repo. Wouldn't that impact other in progress PRs? I think we should revert #34324 and Expensify/expensify-common#651 so that it wouldn't block others.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• revert #36819 #37500

If no regressions arise, payment will be issued on 2024-03-07. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch] The PR that introduced the bug has been identified. Link to the PR:
• [@nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@nkuoch] Determine if we should create a regression test for this bug.
• [@nkuoch] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[youssef-lr]

@lschurr FYI this was tied to a revert to a revet to fix a blocker so no payment is needed.

[miljakljajic]

Sorry - I just realised that myself

[miljakljajic]

I am going to be OOO on the 7th so assigned Lauren, but all good here. @lschurr I will unassign you

[melvin-bot]

@nkuoch, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• revert #36819 #37500

If no regressions arise, payment will be issued on 2024-03-11. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch] The PR that introduced the bug has been identified. Link to the PR: fix: prevent lag when adding code block in task description #36819
• [@nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: prevent lag when adding code block in task description #36819 (comment)
• [@nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No, we just reverted the original PR so far
• [@nkuoch] Determine if we should create a regression test for this bug. No, we just reverted the original PR so far
• [@nkuoch] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No, we just reverted the original PR so far
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: