Split - User can split bill with only one user and billable option is present in split menu

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Manual.
3. Enter amount > Next.
4. Click Split next to one user.
5. Click Add to split.
6. Click Split.
7. In 1:1 DM, click on the split preview.

Expected Result:

In Step 6, user should not be able to split bill with only one user. There is no split bill option from + menu in 1:1 DM.
In Stepp 7, there should be no billable option since it is not present when splitting bill.

Actual Result:

In Step 6, user is able to split bill with only one user.
In Step 7, the split preview shows billable option.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6396698_1709193921803.bandicam_2024-02-29_08-41-11-218.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #vip-split-p2p-chat-groups

[situchan]

There are 2 bugs reported here.

Split - User can split bill with only one user - regression from #33482
billable option is present in split menu - this is dupe of #37522 and it seems offending PR is being reverted

I think better to revert #33482 as well since it also caused multiple regressions

[puneetlath]

FYI, this is likely fixed by this revert. Will have QA re-test once it is CP'd.

[bernhardoj]

Splitting with one user is not a regression.
#32912 (comment)

[puneetlath]

Was fixed by revert.