[HOLD for payment 2024-03-20] [$250] navigation transition from "transfer balance" screen slides from right instead of left

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction (transfer balance not available for expensifail accounts)
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709850736979019

Action Performed:

1. on mobile, go to account settings > wallet > transfer balance
2. click the back button in the top left corner

Expected Result:

The app should "slide out" the current page, or in other words the transition should begin from the left.

Actual Result:

The app "slides in," or in other words the transition starts from the right.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1709838205.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d17bd9fc5de2c53a
• Upwork Job ID: 1766152600475242496
• Last Price Increase: 2024-03-08

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[m-natarajan]

@mountiny tagging you as per this comment.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The navigation animation is sliding from the right when closing the transfer balance page.

What is the root cause of that problem?

The transfer balance page is a RHP and when we open it, it's the only page in RHP, so going back will use the fallback route.

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Lines 161 to 165 in f0cd513

	<HeaderWithBackButton
	title={translate('common.transferBalance')}
	shouldShowBackButton
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}
	/>

If the fallback route is used, the current page will be replaced with the fallback route resulting in 2 wallet page in the stack.

What changes do you think we should make in order to solve the problem?

Remove the fallback route.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d17bd9fc5de2c53a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[sakluger]

I'm removing the Help Wanted label for now since @mountiny mentioned that he wanted SWM to work on this one. I've asked in Slack if he'd prefer SWM to work on it or if we can accept proposals.

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

Checking this out, its a simple issue and we got a proposal from @bernhardoj so I would just pick them up

[melvin-bot]

❌ There was an error making the offer to @jayeshmangwani for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @bernhardoj for the Contributor role. The BZ member will need to manually hire the contributor.

[mountiny]

@bernhardoj Feel free to raise the PR

[bernhardoj]

PR is ready

[kunj2707]

So its basically pushing the view every time and stacking up.
You just have to maintain the flow and handle the transition.

[melvin-bot]

📣 @kunj2707! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix wrong back navigation transition animation in transfer balance page #37998

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment (Needs manual offer from BZ)
• @bernhardoj requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @jayeshmangwani paid $250 via Upwork (LINK)
• ROLE: @bernhardoj sent offer of $250 via Upwork (LINK)

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1766152600475242496/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sakluger]

@jayeshmangwani could you please complete the BZ checklist?

@jayeshmangwani @bernhardoj I've sent out offers via Upwork, please let me know when you've accepted it.

[jayeshmangwani]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav  #33280
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8] Ideal nav  #33280 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: [N/A] It was a huge PR and it may be oversight
• Determine if we should create a regression test for this bug.

Regression Test Proposal

1. Go to account settings > wallet > transfer balance
2. Click the header back button
3. Validate that transfer balance page close animation is slides to the right

Do we agree 👍 or 👎

[jayeshmangwani]

@sakluger BZ checklist completed and accepted Upwork offer

[sakluger]

Thanks everyone! All paid out.