Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Held on #20354] [$500] Chat – Second user is highlighted when create a group using keyboard #38216

Closed
1 of 6 tasks
izarutskaya opened this issue Mar 13, 2024 · 49 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Mar 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.51-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4417998
Email or phone of affected tester (no customers): ponikarchuks+713324@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Сlick on FAB
  4. Click on "Start Chat"
  5. Use the arrow keys, tab key and Enter to select multiple results from the contact lists (at list 3 accounts)

Expected Result:

Selected user is highlighted when create a group using keyboard

Actual Result:

Second user is highlighted when create a group using keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6412108_1710326076086.Second_user_is_highlighted_when_create_a_group_using_keyboard.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015834298cf682f992
  • Upwork Job ID: 1769865643699728384
  • Last Price Increase: 2024-07-16
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@izarutskaya
Copy link
Author

@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think that this bug might be related to #vip-vsb
CC @quinthar

@dragnoir
Copy link
Contributor

HOLD for #34356

@melvin-bot melvin-bot bot added the Overdue label Mar 15, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

@anmurali Huh... This is 4 days overdue. Who can take care of this?

@anmurali anmurali added the External Added to denote the issue can be worked on by a contributor label Mar 18, 2024
@melvin-bot melvin-bot bot changed the title Chat – Second user is highlighted when create a group using keyboard [$500] Chat – Second user is highlighted when create a group using keyboard Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015834298cf682f992

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
@anmurali anmurali added Weekly KSv2 and removed Daily KSv2 labels Mar 18, 2024
@anmurali anmurali changed the title [$500] Chat – Second user is highlighted when create a group using keyboard [Held on #34356] [$500] Chat – Second user is highlighted when create a group using keyboard Mar 18, 2024
@Krishna2323
Copy link
Contributor

Proposal incase we don't change OptionsSelcetor to SelectionList in NewChatPage in any other PR.`

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat – Second user is highlighted when create a group using keyboard

What is the root cause of that problem?

We are using OptionsSelector.

What changes do you think we should make in order to solve the problem?

Update to SelectionList.

Result

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 18, 2024
@s77rt
Copy link
Contributor

s77rt commented Mar 19, 2024

Holding on #20354 since #34356 is reverted

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@anmurali anmurali changed the title [Held on #34356] [$500] Chat – Second user is highlighted when create a group using keyboard [Held on #20354] [$500] Chat – Second user is highlighted when create a group using keyboard Mar 25, 2024
@anmurali
Copy link

Changed the title accordingly. Still holding as #20354 is in progress

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@anmurali anmurali added Weekly KSv2 and removed Daily KSv2 labels Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label May 28, 2024
@s77rt
Copy link
Contributor

s77rt commented May 29, 2024

To be closed

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fifth week)

Copy link

melvin-bot bot commented Jun 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@s77rt
Copy link
Contributor

s77rt commented Jun 8, 2024

To be closed

@melvin-bot melvin-bot bot removed the Overdue label Jun 8, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@s77rt
Copy link
Contributor

s77rt commented Jun 17, 2024

@anmurali Please close this

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 18, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Jun 25, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jun 26, 2024
@s77rt
Copy link
Contributor

s77rt commented Jun 26, 2024

To be closed

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2024
Copy link

melvin-bot bot commented Jul 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (6th week)

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2024
@s77rt
Copy link
Contributor

s77rt commented Jul 5, 2024

To be closed

@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (7th week) Are we ok to close this?

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@s77rt
Copy link
Contributor

s77rt commented Jul 15, 2024

@anmurali Can you please close this one

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (8th week)
Closing as there has been no action on this at all for an extended period.
@anmurali pls feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants