Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 3 vulnerabilities #38312

Closed
melvin-bot bot opened this issue Mar 14, 2024 · 17 comments
Closed

[Snyk] Fix for 3 vulnerabilities #38312

melvin-bot bot opened this issue Mar 14, 2024 · 17 comments
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@melvin-bot
Copy link

melvin-bot bot commented Mar 14, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Denial of Service (DoS)
SNYK-JS-ELECTRON-6405830
No No Known Exploit
medium severity Missing Release of Resource after Effective Lifetime
SNYK-JS-INFLIGHT-6095116
Yes Proof of Concept
high severity Prototype Pollution
SNYK-JS-UNSETVALUE-2400660
Yes No Known Exploit
Commit messages
Package name: @storybook/react The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Denial of Service (DoS)
🦉 Prototype Pollution

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017f0044a167283b00
  • Upwork Job ID: 1768276781396721664
  • Last Price Increase: 2024-03-14
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Mar 14, 2024
Copy link
Author

melvin-bot bot commented Mar 14, 2024

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

Copy link
Author

melvin-bot bot commented Mar 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017f0044a167283b00

Copy link
Author

melvin-bot bot commented Mar 14, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

@allroundexperts
Copy link
Contributor

@yuwenmemon Since the original PR had conflicts, I created a new one #39372. Can you please review / merge?

@yuwenmemon yuwenmemon self-assigned this Apr 1, 2024
@yuwenmemon
Copy link
Contributor

This was deployed to prod.

@allroundexperts
Copy link
Contributor

@yuwenmemon My compensation is pending here. Also, since this involved up-gradation of storybook (Took quite some time as evident from the merged PR), I would like to request a compensation of $500. Please review the request. Thanks!

@yuwenmemon yuwenmemon reopened this Apr 19, 2024
@yuwenmemon
Copy link
Contributor

That's fine by me!

@yuwenmemon yuwenmemon added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 19, 2024
Copy link
Author

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 19, 2024
@yuwenmemon yuwenmemon removed the Bug Something is broken. Auto assigns a BugZero manager. label Apr 19, 2024
@yuwenmemon
Copy link
Contributor

@greg-schroeder Can you handle @allroundexperts's request above?

Copy link
Author

melvin-bot bot commented Apr 26, 2024

@yuwenmemon, @greg-schroeder, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link
Author

melvin-bot bot commented Apr 30, 2024

@yuwenmemon, @greg-schroeder, @allroundexperts 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link
Author

melvin-bot bot commented May 2, 2024

@yuwenmemon, @greg-schroeder, @allroundexperts 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@yuwenmemon
Copy link
Contributor

@greg-schroeder any update on this one?

@greg-schroeder
Copy link
Contributor

greg-schroeder commented May 9, 2024

Apologies for the delay on this, for some reason my GH<>Slack zap isn't picking up my mentions on this issue 🤔

Also it's better to add Awaiting Payment label or [HOLD for payment] in the title so it's easier to see this is waiting for payment, as that's how we generally filter them on the BZ team.

@greg-schroeder
Copy link
Contributor

greg-schroeder commented May 9, 2024

Creating a payment issue to generate a new upwork job and will send a manual offer: #41875

@greg-schroeder
Copy link
Contributor

Oh, you're a NewDot-eligible C+. So, yeah, ignore that. You can make a manual request for $500 for this issue and link to this comment for confirmation.

@JmillsExpensify
Copy link

$500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants