[$500] Workspace – WS name and avatar changed to default after deleting WS

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team

Issue found when executing PR #38365

Action Performed:

1. Log in
2. Create new WS
3. Change name and avatar
4. Go to chats
5. Go back to WS settings and delete WS
6. Go back to chats and observe WS name and avatar

Expected Result:

WS name and avatar don’t change to default after deleting WS

Actual Result:

WS name and avatar change to default after deleting WS

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418213_1710787396452.WS_name_changed_to_default_after_deleting_WS.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d7aa9ecfc6f965dd
• Upwork Job ID: 1773074259104903168
• Last Price Increase: 2024-09-30
• Automatic offers:
• DylanDylann | Reviewer | 0

Issue Owner

Current Issue Owner: @grgia

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[alexpensify]

Adding this one to my testing list.

[alexpensify]

No update yet

[alexpensify]

I'll test this one soon.

[alexpensify]

On my testing list

[alexpensify]

I tested and confirmed that the avatar changes when you delete the workspace. The name does not change.

Before

After

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d7aa9ecfc6f965dd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[alexpensify]

@alitoshmatov - we need to prevent the avatar from changing when a workspace is deleted. It looks like the other mention here does not appear in my recent tests.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS name and avatar change to default after deleting WS

What is the root cause of that problem?

We're clearing the workspace avatar here when deleting workspace. And after coming online, the workspace will be removed completely from Onyx.

What changes do you think we should make in order to solve the problem?

Since after coming online, the workspace will be removed completely from Onyx. We'll need to add a new field oldPolicyAvatar in the workspace-related reports, just like we do for workspace name here. Then when retrieving avatar for the report, we'll use oldPolicyAvatar of the report first if it exists (similar to here). This will make sure the archived report can still show the workspace avatar even after the workspace data itself was cleared. This is the same approach we currently use to preserve the policy name, that's why we can see the workspace name does not disappear, but the workspace avatar disappears.

There might be similar back-end change needed to add support for the oldPolicyAvatar field.

Optionallly, we can remove this line to preserve the workspace avatar in the policy in Onyx after deleting.

Also we might want to do the same in related flow like removing members, because the workspace data will also be deleted for that removed member.

What alternative solutions did you explore? (Optional)

When retrieving the workspace avatar for display, for example in here, fallback to avatarUrl first, if avatar is empty.

Another approach is we can modify the back-end to still return the deleted policy in the API response (and subsequent ReconnectApp API calls), so we still have the policy data in the front-end to show in archived reports, ... but we don't show or have any entry point to that deleted policy's pages in the front-end if the policy was deleted.

[alexpensify]

No update yet, this one needs a proposal review.

[alexpensify]

@alitoshmatov - please keep me posted if you cannot review this one and I'll reassign it. Thanks!

[alitoshmatov]

@alexpensify Sorry, had some work on my plate, please reassign.

[DylanDylann]

I am happy to take over this one if @alitoshmatov is busy

[grgia]

adding to hot picks and unassigning

[alexpensify]

No update yet, this one is still a hot pick.

[DylanDylann]

@alexpensify Any update here?

[alexpensify]

No update yet, it's still a hot pick

[alexpensify]

Still a hot pick

[alexpensify]

Hot Pick

[DylanDylann]

@alexpensify Should we continue on this issue anymore? It has been delayed for 5 months

[alexpensify]

@DylanDylann, good call; I'm going to close now.

[DylanDylann]

@alexpensify Could you please handle payment in this issue? As mentioned on Slack, C and C+ should get fully paid because we are hired and did the work (The PR was created)

cc @nkdengineer

[alexpensify]

Thank you for flagging, my mistake here. Let me reopen and prepare the payment process tomorrow.

[melvin-bot]

Upwork job price has been updated to $259

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

Upwork job price has been updated to $500

[alexpensify]

Payouts due: 09-30-2024

• Contributor: $500 @nkdengineer - I need to create a new Upwork job
• Contributor+: $500 @DylanDylann - I've paid

Upwork job is here. This one falls under the $500 amount since it was opened before the pricing change.

[alexpensify]

@nkdengineer - I sent an offer here: https://www.upwork.com/nx/wm/offer/104201713. Please accept and I can complete the payment process. Thanks!

[nkdengineer]

@alexpensify Thanks! I accepted however it seems the issue number in the offer is incorrect (#45879). If possible please update it to avoid confusion later.

[alexpensify]

@nkdengineer thanks for flagging that my edits didn't save, I created a new offer here: https://www.upwork.com/nx/wm/offer/104222417

I'll withdraw the other one and please accept the new one. Sorry for the extra step but Upwork is blocking me from edits.

[nkdengineer]

@alexpensify Sure thing, I accepted

[alexpensify]

Thanks and all set here. I've completed the payment process in Upwork.