Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [$250] [Payment card / Subscription] Implement “Change billing currency” action #38619

Closed
MitchExpensify opened this issue Mar 19, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Mar 19, 2024

This covers this section of the doc @fabioh8010

Mode: Accessible only on desktop and web
Onyx keys: ONYXKEYS.COLLECTION.POLICY, ONYXKEYS.FUND_LIST
API commands: UpdateBillingCardCurrency
Component path: src/settings/subscription/PaymentCard/ChangeBillingCurrency.tsx

image

Create an empty screen with a route

Route for page - /settings/subscription/change-billing-currency
Before building the actual screen content we need to create an empty ChangeBillingCurrency screen and add it to the navigation.
The screen has to be defined in the SettingsModalStackNavigator and SCREENS.RIGHT_MODAL.SETTINGS and it should be available only for desktop and web.

Implement Form wrapper

We will define and with the provided Submit button text and handler.

To implement the currency selector list modal we will use decoupled before and from the WorkspaceOwnerPaymentCardForm to reuse it here.

Note section
image

This is going to be a basic component with for the link(pricing page).

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011778e5bbd693de04
  • Upwork Job ID: 1770152613632573440
  • Last Price Increase: 2024-07-02
Issue OwnerCurrent Issue Owner: @zanyrenney
@MitchExpensify MitchExpensify added the External Added to denote the issue can be worked on by a contributor label Mar 19, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Implement “Change billing currency” action [$500] [Payment card / Subscription] Implement “Change billing currency” action Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011778e5bbd693de04

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 19, 2024
@MitchExpensify MitchExpensify removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Mar 19, 2024
@ShridharGoel
Copy link
Contributor

I would like to work on this. Can more context be added?

@MitchExpensify
Copy link
Contributor Author

This is not ready for proposals @ShridharGoel, we'll apply the help wanted label again when it is - Thanks!

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2024
@trjExpensify trjExpensify assigned narefyev91 and unassigned fabioh8010 Jun 5, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
@trjExpensify trjExpensify added Daily KSv2 Overdue and removed Monthly KSv2 labels Jun 5, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 5, 2024
@narefyev91
Copy link
Contributor

Today updates - start working on implementation for re-usable form (same will be for this one #38630)
WIP

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@narefyev91
Copy link
Contributor

Today report - build re-usable form to use in both places for change currency. Tomorrow plan to add latest code peaces and open a PR for a review

@narefyev91 narefyev91 mentioned this issue Jun 12, 2024
50 tasks
@trjExpensify trjExpensify added Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Jul 2, 2024
Copy link

melvin-bot bot commented Jul 2, 2024

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@trjExpensify trjExpensify changed the title [$500] [Payment card / Subscription] Implement “Change billing currency” action [$250] [Payment card / Subscription] Implement “Change billing currency” action Jul 2, 2024
Copy link

melvin-bot bot commented Jul 2, 2024

Upwork job price has been updated to $250

@trjExpensify
Copy link
Contributor

PR is merged, automation should take care of adding the awaiting payment label and then we'll need to pay out @situchan for the C+ review.

Regression tests will be added centrally for this project as it wraps up.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Payment card / Subscription] Implement “Change billing currency” action [HOLD for payment 2024-07-10] [$250] [Payment card / Subscription] Implement “Change billing currency” action Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @narefyev91 does not require payment (Contractor)
  • @situchan requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jul 3, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@zanyrenney
Copy link
Contributor

@narefyev91 does not require payment (Contractor)
@situchan requires payment (Needs manual offer from BZ) ~I have sent you an job offer. please accept!

@zanyrenney
Copy link
Contributor

@situchan please also propose the regression test!

@blimpich
Copy link
Contributor

No regression test proposal needed I think. This is a new feature and we've written a suite of regression tests to be used by applause once the full project/feature is ready.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 10, 2024
@situchan
Copy link
Contributor

@zanyrenney I accepted invite.

Copy link

melvin-bot bot commented Jul 10, 2024

Payment Summary

Upwork Job

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1770152613632573440/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@zanyrenney
Copy link
Contributor

waiting on @situchan accepting offer

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2024
@zanyrenney
Copy link
Contributor

payment summary

Contributor: @narefyev91 is from an agency-contributor and not due payment
ROLE: @situchan paid $(250) via Upwork - https://www.upwork.com/nx/wm/workroom/37844612/overview?nav_dir=pop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

9 participants