[HOLD for payment 2024-06-11] [$500] Private notes - Hmm its not here page displayed when clicking on thumbnail

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #37566

Action Performed:

1. Navigate to any report
2. Click on header > Private notes
3. Add markdown image to private notes: holla
4. Click on 'Private notes'
5. Click on the image

Expected Result:

• Image should be opened in the attachment carousel just like any image added to Expensify Chat

Actual Result:

• Hmm its not here page is displayed.
• And markdown images are rendered in Private notes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423400_1711129594737.Screen_Recording_2024-03-22_at_8.44.37_in_the_evening.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c6ef0c33505c63ef
• Upwork Job ID: 1771446597185703936
• Last Price Increase: 2024-03-23
• Automatic offers:
• shubham1206agra | Reviewer | 0

Issue Owner

Current Issue Owner: @MitchExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[situchan]

Don't think this is blocker since markdown image is new feature and still WIP of polish

cc: @kidroca

[chiragsalian]

Yup, I agree too. This does not feel blocker-worthy since it's a new feature. A simple resolution would be to revert the feature here - #37566 but I would prefer if move forward and tidy up this bug.

[roryabraham]

edge case that I wouldn't consider much of a blocker, but what I would recommend is that it opens an attachment carousel that only includes attachments in the private notes message.

[roryabraham]

in my opinion the value of inline images way outweighs the downside of this bug, so I wouldn't want to see us revert that because of this

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Private notes - Hmm its not here page displayed when clicking on thumbnail

What is the root cause of that problem?

• We use ImageRenderer to display image
• When clicking on an image to open the attachment modal, onPress is called, it works well with report attachments. But in case of private note, the not here page is displayed because we do not have route for this attachment

What changes do you think we should make in order to solve the problem?

• We need to create a new attachment page to display image for other images that do not belong to report.

1. Create a CommonAttachments page:

function CommonAttachments({route}: ReportAttachmentsProps) {
    const source = Number(route.params.source) || route.params.source;
    const imageSource = tryResolveUrlFromApiRoot(source);
    return (
        <AttachmentModal
            allowDownload
            defaultOpen
            originalFileName='test-image.jpg'
            source={imageSource}
            onModalClose={() => {
                Navigation.goBack();
            }}
        />
    );
}

2. In here, add:

    ATTACHMENTS: 'attachments',

3. In here, add:

    ATTACHMENTS: {
        route: '/attachment',
        getRoute: (source: string) => `attachment?source=${encodeURIComponent(source)}` as const
    }

4. In here, add:

                 <RootStack.Screen
                    name={SCREENS.ATTACHMENTS}
                    options={{
                        headerShown: false,
                        presentation: 'transparentModal',
                    }}
                    getComponent={loadCommonAttachments}
                    listeners={modalScreenListeners}
                />

5. In here, add:

        [SCREENS.ATTACHMENTS]: ROUTES.ATTACHMENTS.route,

6. Update this to:

                    onPress={() => {
                       if(report?.reportID){
                        const route = ROUTES.REPORT_ATTACHMENTS.getRoute(report?.reportID ?? '', source);
                        Navigation.navigate(route);
                       }
                       else {
                        const route = ROUTES.ATTACHMENTS.getRoute(source)
                        Navigation.navigate(route)
                       }
                    }}

What alternative solutions did you explore? (Optional)

• NA

Result

Screen.Recording.2024-03-23.at.12.49.59.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c6ef0c33505c63ef

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix error when clicking on attachment note #40844

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@chiragsalian, @MitchExpensify, @shubham1206agra, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Payment summary:

• $500 @shubham1206agra requires payment automatic offer (Reviewer)
• $500 @nkdengineer requires payment (Needs manual offer from BZ)

[MitchExpensify]

paid and contract ended, @shubham1206agra 🙇

Do we need to add any new tests here?

[shubham1206agra]

@MitchExpensify I don't think so

[shubham1206agra]

Payment summary:

* $250 @shubham1206agra requires payment [automatic offer](https://www.upwork.com/nx/wm/offer/0) (Reviewer)

* $250  @nkdengineer requires payment (Needs manual offer from BZ)

@MitchExpensify Am I missing something here. Why the payout is decreased here?

[shubham1206agra]

paid and contract ended, @shubham1206agra 🙇

I did not receive any offers from Upwork.

[MitchExpensify]

Am I missing something here. Why the payout is decreased here?

I saw the Upwork job created a $250 amount automatically so I was basing it off that. I will update if $500 is correct

[MitchExpensify]

I think I got my wires crossed with this similar looking job on Upwork: https://www.upwork.com/nx/wm/workroom/37532304/details

Sorry about that @shubham1206agra ! Rectifying my mistake here https://www.upwork.com/nx/wm/offer/102750200

[shubham1206agra]

@MitchExpensify Accepted offer

[MitchExpensify]

Paid and contract ended, thanks! Do we need BZ steps here?

[shubham1206agra]

No

[chiragsalian]

@MitchExpensify anything pending here or can we close this out.

[nkdengineer]

Sorry @MitchExpensify It seems I wasn't paid here, could you please reopen the issue to help with this?

TIA

[MitchExpensify]

Oh weird, it looks like the automation flagged you as due to be paid via New Expensify so I thought we were all done:

@nkdengineer requires payment (Needs manual offer from BZ)

Here's a new offer to resolve this https://www.upwork.com/nx/wm/offer/102961478

[MitchExpensify]

Paid and contract ended, thanks for the catch @nkdengineer