Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-08] Web - Chat - Composer jumps when entering first emoji #39267

Closed
1 of 6 tasks
m-natarajan opened this issue Mar 29, 2024 · 33 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

m-natarajan commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1.Go to staging.new.expensify.com/
2.Go to any chat
3.Enter an emoji

Expected Result:

The composer will not jump

Actual Result:

The composer jumps when entering the first emoji

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

20240329_233527.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Mar 29, 2024
@m-natarajan
Copy link
Author

We think this bug might be related to #vip-vsb

@m-natarajan
Copy link
Author

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@francoisl
Copy link
Contributor

I can repro, this comes from the Live Markdown preview #38152. Not sure if it's worth being a blocker though. Looks like there are other open blockers due to the markdown preview anyway, let's see if we end up reverting it.

cc @thienlnam for visibility.

@thienlnam
Copy link
Contributor

Not a blocker, I've added it to the main tracking list with a high priority

@BartoszGrajdek
Copy link
Contributor

Hi! I'm Bartosz from SWM / react-native-live-markdown team - I'll be taking a look into what's happening here later today! 👀

@slafortune
Copy link
Contributor

@BartoszGrajdek I've assigned you 👍

Copy link

melvin-bot bot commented Apr 5, 2024

@slafortune, @thienlnam, @BartoszGrajdek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Apr 12, 2024

@slafortune @thienlnam @BartoszGrajdek this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Skalakid
Copy link
Contributor

I opened PR with the fix for review :D

@slafortune
Copy link
Contributor

@thienlnam @Skalakid @BartoszGrajdek I'll be out until 4/22, not assigning another BZ since this is in a good place with you all to keep it moving forward 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 1, 2024
@melvin-bot melvin-bot bot changed the title Web - Chat - Composer jumps when entering first emoji [HOLD for payment 2024-05-08] Web - Chat - Composer jumps when entering first emoji May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 1, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
  • [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@BartoszGrajdek] Determine if we should create a regression test for this bug.
  • [@BartoszGrajdek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 7, 2024
@slafortune
Copy link
Contributor

@BartoszGrajdek Can you complete the checklist above?

@slafortune
Copy link
Contributor

@BartoszGrajdek does not require payment (Contractor)

@BartoszGrajdek
Copy link
Contributor

@BartoszGrajdek Can you complete the checklist above?

I believe @Skalakid was the one who actually fixed this

Copy link

melvin-bot bot commented May 8, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@fedirjh
Copy link
Contributor

fedirjh commented May 13, 2024

cc @slafortune Could you please reopen this issue to handle the payment for the C+ review? Thank you.

@thienlnam thienlnam reopened this May 13, 2024
@slafortune
Copy link
Contributor

Shoot! I am sorry about that @fedirjh ! Offer sent here - https://www.upwork.com/nx/wm/offer/102318459

@fedirjh
Copy link
Contributor

fedirjh commented May 15, 2024

@slafortune Thank you. Accepted.

@slafortune
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants