Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Awaiting Payment 14th May] [Wave Collect] [Xero] [Import Flow] Create the Customers page #39733

Closed
lakchote opened this issue Apr 5, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017a5564502643da83
  • Upwork Job ID: 1790330441151033344
  • Last Price Increase: 2024-05-14
  • Automatic offers:
    • hungvu193 | Contributor | 0
@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@lakchote lakchote changed the title [Wave Collect] [Xero] [Import Flow] Create the Customers page [HOLD #39727] [Wave Collect] [Xero] [Import Flow] Create the Customers page Apr 15, 2024
@zanyrenney
Copy link
Contributor

As is stated in the Xero authorization flow needs to be complete first.

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I'd like to work on this issue!

@zanyrenney
Copy link
Contributor

zanyrenney commented Apr 26, 2024

Woo great @filip-solecki how are you getting on with this one? is it still on hold for QBO?

@melvin-bot melvin-bot bot removed the Overdue label Apr 26, 2024
@hungvu193
Copy link
Contributor

I can take this over as discussion here: https://expensify.slack.com/archives/C036QM0SLJK/p1714382043481879?thread_ts=1713799302.291019&cid=C036QM0SLJK

Here's the draft PR:
#41377

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 1, 2024
@hungvu193
Copy link
Contributor

PR is merged.

@trjExpensify
Copy link
Contributor

Deployed to production 2 days ago.

@trjExpensify trjExpensify changed the title [HOLD #39727] [Wave Collect] [Xero] [Import Flow] Create the Customers page [Awaiting Payment 14th May] [Wave Collect] [Xero] [Import Flow] Create the Customers page May 9, 2024
@trjExpensify trjExpensify added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels May 9, 2024
@melvin-bot melvin-bot bot added the Overdue label May 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@zanyrenney zanyrenney added External Added to denote the issue can be worked on by a contributor Overdue labels May 14, 2024
Copy link

melvin-bot bot commented May 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017a5564502643da83

@melvin-bot melvin-bot bot changed the title [Awaiting Payment 14th May] [Wave Collect] [Xero] [Import Flow] Create the Customers page [$250] [Awaiting Payment 14th May] [Wave Collect] [Xero] [Import Flow] Create the Customers page May 14, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 14, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Weekly KSv2 labels May 14, 2024
Copy link

melvin-bot bot commented May 14, 2024

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@Expensify Expensify deleted a comment from melvin-bot bot May 14, 2024
@hungvu193
Copy link
Contributor

Hey @zanyrenney, Xero project will be paid as flat price (when it's done), so no payment needed here
cc @trjExpensify

@zanyrenney
Copy link
Contributor

Nice, thanks so much @hungvu193

@trjExpensify how come you added the "awaiting payment [due date] to the title?

@trjExpensify
Copy link
Contributor

Automation would usually do that, but it failed in this instance. The awaiting payment date still tells us when the regression period ends, and when we should close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

6 participants