[HOLD for payment 2024-06-11] [$250] [Search v1] Implement sorting

[luacmartins]

Implement this section of the design doc - https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=kix.sjzpozsidr9q

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df1764b96ba68f02
• Upwork Job ID: 1791073930935115776
• Last Price Increase: 2024-05-16
• Automatic offers:
• c3024 | Contributor | 102482315

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

On hold

[luacmartins]

Taking off hold, we'll start implementation shortly.

[Kicu]

Hey I will be starting to work on this.

[melvin-bot]

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Kicu]

asked a question about sorting here: #42248 (comment)

[luacmartins]

The current API PR is sorting the from and to columns by accountID, but we ultimately want to sort by displayName or login since that's what users would expect. I'll work on a follow up to add the additional logic for those columns, since that requires a change in the query.

Also, it seems like we need to support sorting by type and action too, which I'll handle in the follow up as well.

[Kicu]

how do you sort Total by?

[luacmartins]

We're coalescing the amounts, i.e. COALESCE(t.modifiedAmount, t.amount)

[rayane-djouah]

Heads up, I'll be mostly offline until June 5th, 2024. I can still review this issue, but my response might be slower. If there is something urgent, please reassign it. Thanks!

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search v1] Add sorting  #42248

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @c3024 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[abekkala]

PAYMENT SUMMARY FOR JUNE 11

• Fix: @Kicu - SWM - no payment required
• PR Review: @c3024 [$250, if no regressions] offer link

[abekkala]

@c3024 payment sent and contract ended - thank you! 🎉