[$500] [HOLD for payment 2024-05-08] CRITICAL: [Send invoice] Implement Send Invoice flow from Global Create

[cristipaval]

Part of the Invoicing V0.1 project

Main issue: https://github.com/Expensify/Expensify/issues/341717
Doc section: Invoicing V1
Project: #vip-billpay

Feature Description

Send Invoice from Global Create

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e31d2e6653cca734
• Upwork Job ID: 1788335672367525888
• Last Price Increase: 2024-05-08

[melvin-bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Updates:

• Updated IOU steps to support invoices flow: start, participants, confirmation.
• Implemented a new Send from screen to support invoice sender updates.
• Implemented building of optimistic data for SendInvoice api request, as well as preparing params/onyx updates, but it's not tested yet

TODOs:

• Resolve some left TODOs
• Fix lint and TS issues
• Improve invoice room chat creation (still need a final decision regarding receiver info storage)
• Do UI improvements
• Test the flow in different scenarios on different platforms and make improvements where necessary

Screenshots/recordings

web12.mp4

[VickyStash]

Updates:

• resolved TS-related issues
• fixed invoice creation from global create in case invoice room report for sender/receiver already exists
• implemented function for invite report action optimistic building
• resolved left TODOs for send invoice functionality
• tested functionality on web using offline mode

TODOs:

• confirm all Spanish translations
• fix lint issues
• do UI improvements
• test the flow in different scenarios on mobile platforms and make improvements where necessary
• check the implementation using staging API endpoints (can be done when API is deployed)

[VickyStash]

Updates:

• Enabled receipt file attachment
• Conflicts resolution / ts fixes/ lint fixes
• UI improvements
• Confirmed and fixed Spanish translations internally
• Fix report preview message
• Started to prepare PR for review

TODOs:

• Fix canSendInvoice check
• Test the flow in different scenarios on mobile platforms and make improvements where necessary
• Check the implementation using staging API endpoints (can be done when API is deployed)
• Prepare PR for review

[alexpensify]

Heads up, I will be offline until Tuesday, April 23, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[VickyStash]

Though we a still waiting for some API fixes, the PR related to this issue has been opened for review

[danielrvidal]

Are we still waiting on API fixed for this one? If so, could we link them here? I saw the PR linked above was merged, woo!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[shubham1206agra]

Assign me as reviewer of #40015

[cristipaval]

Are we still waiting on API fixed for this one? If so, could we link them here? I saw the PR linked above was merged, woo!

This issue will be closed when the PR hits production. We have different issues for API fixes we need.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Implement Send Invoice flow from Global Create #40015

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• C+: @shubham1206agra paid $500 via Upwork (LINK)-- there is regression, but this C+ was involved after for the clean up.

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e31d2e6653cca734

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $500

[alexpensify]

@shubham1206agra - please accept the Upwork invite and I can complete the payment process. Thanks!

[shubham1206agra]

@alexpensify Accepted.

[alexpensify]

Thanks! I've completed the payment process in Upwork and am going to close this GH now.