[HOLD for payment 2024-05-08] CRITICAL: [Invoice Rooms] Implement Invoice rooms with individual receivers in the App

[cristipaval]

Part of the Invoicing V0.1 project

Main issue: https://github.com/Expensify/Expensify/issues/341717
Doc section: Invoicing V1 - Invoice Rooms
Project: #vip-billpay

Feature Description

Invoice rooms with individual receivers.

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

Updates:

1. Looks like I have finished with the invoice room UI. The app renders all the information in order with the doc.
2. Once the backend is ready, we probably have some frontend issues. Right now I use only optimistic data from Implement Send Invoice flow from Global Create #40015.

To do:

1. Get done with nested pages.

Screenshot

[cristipaval]

@rezkiy37 Could you please post an update here?

[rezkiy37]

Updates:

1. Updated title and subtitle logic to render accordingly with the doc.
2. Refactor changes.
3. Other monir changes.

To do:

1. Test with the backend.
2. Polish.

[rezkiy37]

Also, we are waiting for the backend fixes.

[cristipaval]

WIP. waiting for the next Auth deploy

[rezkiy37]

The PR has been opened for review.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Implement Invoice rooms with individual receivers #40303

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rezkiy37] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[danielrvidal]

@waterim what is the plan for this one? I was not sure if this one should be getting worked on or not.

[danielrvidal]

Aw, actually is this just a holding issue for the whole project? So there are a lot of things still being done so this is open.

[davidcardoza]

@cristipaval What is this issue being used for?

[cristipaval]

This was part of the implementation phase of the project. The work has been merged but it is still open for the C+ payment.

[davidcardoza]

Ah okay, thanks that's helpful.

[rezkiy37]

I am proposing regression test steps today.

[rezkiy37]

Regression Test Proposal

1. Send an invoice.
2. Open an invoice report room.
3. Verify that the room and its actions look properly.
4. Click on an invoice report preview.
5. Verify that the invoice report looks properly.

Do we agree 👍 or 👎

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[cristipaval]

Assigned @rushatgabhane as the C+ who reviewed the PR

[rushatgabhane]

Regression steps that we need to add -

1. Click green + icon
2. Send an invoice to anyone.
3. Verify that the app redirects to an invoice room.
4. Verify that the room header says "Invoices".
5. Click on an invoice report preview.
6. Verify that an IOU opens.

[rushatgabhane]

@kevinksullivan could you please attach payment summary 🙇

[cristipaval]

@kevinksullivan, @rushatgabhane is the only contributor to pay here, for the C+ review

[melvin-bot]

@cristipaval, @kevinksullivan, @rushatgabhane, @rezkiy37 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cristipaval, @kevinksullivan, @rushatgabhane, @rezkiy37 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@cristipaval, @kevinksullivan, @rushatgabhane, @rezkiy37 Huh... This is 4 days overdue. Who can take care of this?

[kevinksullivan]

Payment summary:

• @rushatgabhane $500

[rushatgabhane]

@kevinksullivan should this be $500 because critical?

[kevinksullivan]

ah yes, sorry about that. Updated

[JmillsExpensify]

$500 approved for @rushatgabhane