Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Android - Unable to access popup menu while "New message" marker is visible #40108

Closed
1 of 6 tasks
kavimuru opened this issue Apr 11, 2024 · 44 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Apr 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Not sure this is same root cause of #40048
Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Open a chat with multiple messages in history
  2. Mark the last message as unread
  3. Scroll up through the messages until "New message" marker shows up
  4. Hold on any message to access the popup menu

Expected Result:

Pop up menu should open up

Actual Result:

Pop up menu doesn't show up, nothing happens when user holds on a single comment

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445817_1712836444874.Screen_Recording_20240411_144850_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cc3abc850cbdd73c
  • Upwork Job ID: 1778840627568414720
  • Last Price Increase: 2024-04-18
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 11, 2024
@melvin-bot melvin-bot bot removed the Hourly KSv2 label Apr 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair
Copy link
Contributor

arosiclair commented Apr 11, 2024

I reproduced on Android in v1.4.62-3. Not reproducible on iOS.

@arosiclair
Copy link
Contributor

No PR's are sticking out to me in the deploy checklist and I'm not currently able to build Android due to this so I'm a bit stuck here.

@arosiclair
Copy link
Contributor

Not reproducible in v1.4.61-8

Android build is fixed on main now. In dev, what I'm seeing is that the long press only works on the last handful of report actions at the bottom. Scrolling up and trying earlier report actions does not work. The "New message" marker is not needed.

@arosiclair
Copy link
Contributor

I would guess this is related to #13767 according to comments on similar issues here.

@WoLewicki or @roryabraham either of you have an idea?

@arosiclair
Copy link
Contributor

I added logs to our showPopover function here and executeSecondaryInteraction functions here. Even when the context menu works, there is no log from PressableWithSecondaryInteraction so I'm deeply confused on what's going wrong here.

@isabelastisser
Copy link
Contributor

@arosiclair, is there anything I can do here to help?

Bump @WojtekBoman and @roryabraham on Andrew's message above.

@arosiclair
Copy link
Contributor

@arosiclair, is there anything I can do here to help?

Thanks but I don't think so atm.

So at this point, I've burned an entire day trying to figure this out and haven't really made any progress. The information that I have is

  • Long presses only work on the first screen of report actions. Our long press handler does not work on any actions above that.
  • This is not reproducible on prod so this is definitely caused by the current deploy
  • From the list of PR's, the fabric PR is the only relevant change that I can see
    • I'm pretty confident this is the root cause, but I cannot successfully build Android after reverting to verify

I'll add External in case any contributors have better luck but also re-assign since @roryabraham was managing that PR. cc @WojtekBoman @j-piasecki @ishpaul777

@arosiclair arosiclair added the External Added to denote the issue can be worked on by a contributor label Apr 12, 2024
@melvin-bot melvin-bot bot changed the title Android - Unable to access popup menu while "New message" marker is visible [$250] Android - Unable to access popup menu while "New message" marker is visible Apr 12, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01cc3abc850cbdd73c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 12, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 Weekly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title [$1000] Android - Unable to access popup menu while "New message" marker is visible [HOLD for payment 2024-04-25] [$1000] Android - Unable to access popup menu while "New message" marker is visible Apr 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

  • @c3024 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 18, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
  • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@c3024] Determine if we should create a regression test for this bug.
  • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@kosmydel kosmydel mentioned this issue Apr 19, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 19, 2024
@roryabraham roryabraham changed the title [HOLD for payment 2024-04-25] [$1000] Android - Unable to access popup menu while "New message" marker is visible [$1000] Android - Unable to access popup menu while "New message" marker is visible Apr 19, 2024
@roryabraham roryabraham removed the Awaiting Payment Auto-added when associated PR is deployed to production label Apr 19, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 19, 2024
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Apr 22, 2024
@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@WoLewicki
Copy link
Contributor

I think this issue should be resolved already by #40560 or #40905.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

This issue has not been updated in over 15 days. @roryabraham, @c3024 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@c3024
Copy link
Contributor

c3024 commented May 22, 2024

@roryabraham this appears to be resolved. Could you please close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants