Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task – Long string appears instead of assignee in system message when assigning task #40413

Closed
4 of 6 tasks
izarutskaya opened this issue Apr 18, 2024 · 11 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4494366
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in.
  3. Navigate to any chat
  4. Create a task without assignee
  5. Open task report and assign task to me

Expected Result:

System message appears with user name, when assign task without assignee to me

Actual Result:

System message appears - Assigned to , but not a user name, when assign task without assignee to me

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6453308_1713426139344.Task.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya izarutskaya added the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 18, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@greg-schroeder I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb.

@nkuoch
Copy link
Contributor

nkuoch commented Apr 18, 2024

cc @jasperhuangg or @rlinoz or @thienlnam you might know?

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

I'm checking, but maybe this is also related to the expensi-common update @robertKozik ?

cc: @puneetlath

@robertKozik
Copy link
Contributor

@rlinoz ExpensiMark is still unaware of application data (accountIDs as well) so I think it won't replace the name in such a way.
Can we check EditTaskAssignee command? It returns html with a mention:

            "key": "reportActions_4663769334777431",
            "onyxMethod": "merge",
            "value": {
                "8945435353820593844": {
                    "actionName": "TASKEDITED",
                    "actorAccountID": 14342127,
                    "avatar": "https:\/\/d1wpcgnaa73g0y.cloudfront.net\/75097e10b068c4e37ad6e6134c6305bb1f828938_128.jpeg",
                    "created": "2024-04-18 13:58:25.830",
                    "lastModified": "2024-04-18 13:58:25.830",
                    "message": [
                        {
                            "html": "assigned to <mention-user accountID=14342127><\/mention-user>",
                            "text": "assigned to @Robert ROBERT robert Kozik KOZIK kozik",
                            "type": "COMMENT"
                        }
                    ],
                    "originalMessage": {
                        "assignee": "",
                        "html": "assigned to <mention-user accountID=14342127><\/mention-user>",
                        "lastModified": "2024-04-18 13:58:25.830"
                    },
                    "person": [
                        {
                            "text": "Robert ROBERT robert Kozik KOZIK kozik",
                            "type": "TEXT"
                        }
                    ],
                    "previousReportActionID": "9001584629617700205",
                    "reportActionID": "8945435353820593844",
                    "shouldShow": false
                }
            }

Form data doesn't have any html tag or mention inside:
image

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

Yeah, git bisect led me to this PR: #40200

cc: @bernhardoj @abdulrahuman5196

@bernhardoj
Copy link
Contributor

I can confirm it's from my PR.

@abdulrahuman5196 looks like we need to revert the PR and go with my alternative approach.

@thienlnam
Copy link
Contributor

I created a revert PR here

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants