Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Onboarding - Tapping the Onboarding link does not open the Onboarding menu #40456

Closed
1 of 6 tasks
kbecciv opened this issue Apr 18, 2024 · 6 comments
Closed
1 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - internal Team

Action Performed:

  1. Open New Expensify app
  2. Navigate to any conversation
  3. Send the link to the conversation to https://staging.new.expensify.com/onboarding
  4. Click on the link

Expected Result:

Tapping on the Onboarding link should open the Onboarding menu.

Actual Result:

Tapping the Onboarding link does not open the Onboarding menu, buttons in Compose Box stop working, to get the Onboarding menu, you have to tap on the user profile link and go back.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453539_1713441409578.Record_2024-04-18-16-35-14.1.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 18, 2024

We think that this bug might be related to #vip-vsb

@mountiny mountiny assigned mountiny and unassigned stitesExpensify Apr 19, 2024
@mountiny mountiny added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 19, 2024
@mountiny
Copy link
Contributor

I dont really think this is an issue for not, certainly not a deploy blocker.

I wonder how we should treat this, I will bring this to slack, not sure if we need to allow user to enter the onboarding flow they have completed before again

@mountiny
Copy link
Contributor

Asked here

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@mountiny
Copy link
Contributor

We should not be allowing people to go through the flow multiple times so this should be fine

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants