[HOLD for payment 2024-05-08] [$250] Task - "From" subtitle is present in group task report after user has left the group

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to group chat
3. Create a task
4. Click on the chat header > Leave
5. Go to task report
6. Click on "From" link

Expected Result:

There should not be "From" link because the group chat is no longer accessible

Actual Result:

There is "From" link in the task report when user has left the group chat. Clicking on "From" subtitle leads to skeleton report.
The same issue also happens for group thread after user leaves the group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453890_1713458808249.bandicam_2024-04-19_00-43-34-829.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017c5bacf8c885bcc7
• Upwork Job ID: 1781098555062116352
• Last Price Increase: 2024-04-18

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[luacmartins]

Looking

[luacmartins]

I can reproduce on staging, but not locally. Investigating

[luacmartins]

I'm gonna demote this since it doesn't break any functionality

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017c5bacf8c885bcc7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[DylanDylann]

Can't reproduce

[melvin-bot]

@eVoloshchak, @luacmartins, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Put up a PR in review - #40726

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Conditionally render from on report header #40726

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

@eVoloshchak are you owed payment for reviewing the PR? I'll submit a manual request for you tomorrow.

[eVoloshchak]

are you owed payment for reviewing the PR?

@miljakljajic, yes, for the review of #40726

[miljakljajic]

@eVoloshchak is owed 250 USD for their work reviewing #40726

Thank you!

[JmillsExpensify]

$250 approved for @eVoloshchak