Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Chat - Changing skin tone and selecting emoji moves cursor to left #40504

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 18, 2024 · 26 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Enter :+1 and then click emoji picker
  4. Change the skin tone
  5. Select the emoji
  6. Note the cursor position in compose box

Expected Result:

Changing skin tone and selecting emoji must not move cursor to left

Actual Result:

Changing skin tone and selecting emoji moves cursor to left

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454236_1713471923855.curson.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0198233b222f3033ae
  • Upwork Job ID: 1782441601731379200
  • Last Price Increase: 2024-04-22
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

Production:

Record_2024-04-18-22-55-08_4f9154176b47c00da84e32064abf1c48.mp4

@tgolen
Copy link
Contributor

tgolen commented Apr 18, 2024

I don't think this needs to be a blocker, and I think it can be fixed by contributors. I suspect it could have something to do with #39597

@Skalakid would you mind checking to see if it relates to your PR or not?

@Skalakid
Copy link
Contributor

Hi, @tgolen I was able to reproduce this issue. I think there is a problem inside react-native-live-markdown implementation for Android and I prepared a small fix for it

@tgolen tgolen added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Hourly KSv2 labels Apr 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@tgolen tgolen added the External Added to denote the issue can be worked on by a contributor label Apr 22, 2024
@melvin-bot melvin-bot bot changed the title Android - Chat - Changing skin tone and selecting emoji moves cursor to left [$250] Android - Chat - Changing skin tone and selecting emoji moves cursor to left Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0198233b222f3033ae

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@tgolen tgolen assigned Skalakid and unassigned garrettmknight and paultsimura Apr 22, 2024
@tgolen
Copy link
Contributor

tgolen commented Apr 23, 2024

@Skalakid is this a regression from your PR or is it a separate fix?

bump @Skalakid

@Skalakid
Copy link
Contributor

@tgolen Sorry, I totally missed the notification. This is a separate fix, since we didn't catch bug with cursor positioning on Android when changing text and style simultaneously

@tgolen
Copy link
Contributor

tgolen commented Apr 24, 2024

OK, thanks. I'm going to add the C+ and BZ people back onto this issue then and you can attach your fix to this issue.

@tgolen tgolen added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Current assignee @garrettmknight is eligible for the Bug assigner, not assigning anyone new.

@tgolen tgolen added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Apr 24, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@tgolen tgolen removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 26, 2024
@parasharrajat
Copy link
Member

No PR yet.

@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2024
@Skalakid
Copy link
Contributor

The PR with the fix was already merged to the react-native-live-markdown library. This PR will bump markdown version to the latest in E/App

Copy link

melvin-bot bot commented Apr 30, 2024

@tgolen, @garrettmknight, @parasharrajat, @Skalakid Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Apr 30, 2024
@garrettmknight
Copy link
Contributor

Are we still waiting on #41103 for this one?

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
Copy link

melvin-bot bot commented May 2, 2024

@tgolen @garrettmknight @parasharrajat @Skalakid this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@tgolen
Copy link
Contributor

tgolen commented May 3, 2024

We are still waiting on #41103 for this, yeah.

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@Skalakid
Copy link
Contributor

Skalakid commented May 6, 2024

The react-native-live-markdown version has been bumped in other PR and merged, so the issue should be fixed in E/App

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
@tgolen
Copy link
Contributor

tgolen commented May 6, 2024

OK, so can this GH be closed out then?

@Skalakid
Copy link
Contributor

Skalakid commented May 7, 2024

@tgolen since it is fixed I think yes 👍

@tgolen tgolen closed this as completed May 7, 2024
Copy link

melvin-bot bot commented May 7, 2024

@tgolen @garrettmknight Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants