Pay someone - Letter "s" in "Pay someone" banner is capitalised

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Pay someone
3. Enter amount > Next
4. Click on "Pay Someone" bottom banner

Expected Result:

Letter "s" in "Pay someone" should not be capitalised

Actual Result:

Letter "s" in "Pay someone" is capitalised

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Letter "s" in "Pay someone" is capitalised

What is the root cause of that problem?

The text is not correct

App/src/languages/en.ts

Lines 2656 to 2659 in 68b1ede

	buttonText1: 'Pay Someone, ',
	buttonText2: `get $${CONST.REFERRAL_PROGRAM.REVENUE}.`,
	header: `Pay Someone, get $${CONST.REFERRAL_PROGRAM.REVENUE}`,
	body: `You gotta spend money to make money! Pay someone with Expensify and get $${CONST.REFERRAL_PROGRAM.REVENUE} when they become a customer.`,

What changes do you think we should make in order to solve the problem?

Change it to correct capital.

What alternative solutions did you explore? (Optional)

We need to double check to make sure capitalization is consistent. For example:

App/src/languages/en.ts

Line 580 in 68b1ede

cameraErrorTitle: 'Camera Error',

App/src/languages/en.ts

Line 650 in 68b1ede

nextStep: 'Next Steps',

App/src/languages/en.ts

Line 709 in 68b1ede

enableWallet: 'Enable Wallet',

App/src/languages/en.ts

Line 1160 in 68b1ede

streetAddress: 'Street Address',

App/src/languages/en.ts

Line 1259 in 68b1ede

label: 'Use Device Settings',

App/src/languages/en.ts

Line 1738 in 68b1ede

headerTitle: 'Validate Bank Account',

App/src/languages/en.ts

Line 1816 in 68b1ede

reportFields: 'Report Fields',

App/src/languages/en.ts

Line 2000 in 68b1ede

createAWorkspaceCTA: 'Get Started',

App/src/languages/en.ts

Line 2390 in 68b1ede

title: 'Attachment Error',

[francoisl]

That seems like a simple copy change, no need to block on this. All these came from https://github.com/Expensify/App/pull/39483/files#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785, I'll double-check all the changes there to make sure they look correct. We'll also need to check changes to es.ts.

[francoisl]

We need to double check to make sure capitalization is consistent. For example:

Thanks for linking those, but they all seem like they haven't been changed in a while, and most of them are used as titles, which we do usually capitalize. I'll just update the "Pay Someone, get $250" for now.

[melvin-bot]

This issue has not been updated in over 15 days. @francoisl eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@francoisl, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.