Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Group chat - Custom avatar reverts to default avatar after promoting member to Admin #40586

Closed
6 tasks done
lanitochka17 opened this issue Apr 19, 2024 · 21 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Go to FAB > Start chat
  3. {User A] Create a group chat with User B
  4. {User A] Send a message to chat
  5. [User A] Upload a group chat avatar
  6. [User B] Open the group chat
  7. [User A] Promote User B to Admin
  8. [User B] Wait for a while to receive the update

Expected Result:

Group avatar will not revert to default avatar after promoting User B to admin

Actual Result:

Group avatar reverts to default avatar after promoting User B to admin. However, it changes back to custom avatar after a while

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6455043_1713540210189.20240419_231139.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ee2daa5a2c3e8900
  • Upwork Job ID: 1781378609184792576
  • Last Price Increase: 2024-04-26
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@blimpich
Copy link
Contributor

Looking into this

@blimpich
Copy link
Contributor

@marcaaron do you think this is related to the changes to group-chats?

@blimpich
Copy link
Contributor

Demoting as I don't think this is an actual blocker. Fairly minor. Also wasn't able to reproduce it.

@blimpich blimpich removed the DeployBlockerCash This issue or pull request should block deployment label Apr 19, 2024
@blimpich
Copy link
Contributor

@marcaaron unless you feel like this should be handled as part of group chats I'd say we open this open to contributors and see if anyone else can reproduce and figure out the issue

@blimpich blimpich added Daily KSv2 and removed Hourly KSv2 labels Apr 19, 2024
@marcaaron
Copy link
Contributor

Yeah it could be - I'll add it to the GH Project I have set up to track these. Definitely, agree not a blocker.

Group avatar reverts to default avatar after promoting User B to admin. However, it changes back to custom avatar after a while

Seems like we could possibly be removing it in the optimistic data somewhere.

@marcaaron marcaaron added Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Apr 19, 2024
@melvin-bot melvin-bot bot changed the title Group chat - Custom avatar reverts to default avatar after promoting member to Admin [$250] Group chat - Custom avatar reverts to default avatar after promoting member to Admin Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ee2daa5a2c3e8900

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

Copy link

melvin-bot bot commented Apr 19, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@marcaaron
Copy link
Contributor

@blimpich lmk if you want me to take this one off your hands.

@blimpich
Copy link
Contributor

Will do, I'm good to be the CME for this I think 👍

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@laurenreidexpensify
Copy link
Contributor

waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@dragnoir
Copy link
Contributor

@laurenreidexpensify are you able to reproduce? I was not!

@blimpich
Copy link
Contributor

@laurenreidexpensify I'd say we set this issue to be retested by applause and if they can't reproduce it then we close.

@blimpich blimpich added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Apr 22, 2024
@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@laurenreidexpensify
Copy link
Contributor

WAiting for weekly retesting to confirm if we want to close

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@blimpich
Copy link
Contributor

blimpich commented May 1, 2024

Closing as this isn't reproducible.

@blimpich blimpich closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants