[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] mWeb/Safari - UI - The top part of the UI is white while the page is loading in dark mode

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62.17
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : https://github.com/Expensify/Expensify/issues/302570
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Dark mode should be enabled.

1. Open any chat or room
2. Refresh the page

Expected Result:

The whole UI should be in dark mode.

Actual Result:

The top part of the UI is white while the page is loading in dark mode. The issue appears when refreshing any room, or chat, or LHN and when you kill and re-open Safari.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6456678_1713720715815.KRDX1564.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a67f702d8230d48e
• Upwork Job ID: 1784920320468824064
• Last Price Increase: 2024-04-29
• Automatic offers:
• getusha | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[mountiny]

This is minor ui bug, lets not block deploy on this given we are close to shipping it

[grgia]

@izarutskaya is this reproducible on the previous version?

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The status bar of the mobile web (safari) is white instead of following the splash screen color.

What is the root cause of that problem?

The status bar color is based on the theme-color value

App/web/index.html

Line 7 in 76d6539

<meta name="theme-color" content="">

Since the value is empty, it just follows the device theme. The status bar is then updated depends on the page every time the nav state changes.

App/src/components/CustomStatusBarAndBackground/index.tsx

Lines 63 to 115 in 76d6539

	const updateStatusBarStyle = useCallback(
	(listenerID?: number) => {
	// Check if this function is either called through the current navigation listener
	// react-navigation library has a bug internally, where it can't keep track of the listeners, therefore, sometimes when the useEffect would re-render and we run navigationRef.removeListener the listener isn't removed and we end up with two or more listeners.
	// https://github.com/Expensify/App/issues/34154#issuecomment-1898519399
	if (listenerID !== undefined && listenerID !== listenerCount.current) {
	return;
	}
	// Set the status bar colour depending on the current route.
	// If we don't have any colour defined for a route, fall back to
	// appBG color.
	let currentRoute: ReturnType<typeof navigationRef.getCurrentRoute> | undefined;
	if (navigationRef.isReady()) {
	currentRoute = navigationRef.getCurrentRoute();
	}
	let newStatusBarStyle = theme.statusBarStyle;
	let currentScreenBackgroundColor = theme.appBG;
	if (currentRoute && 'name' in currentRoute && currentRoute.name in theme.PAGE_THEMES) {
	const pageTheme = theme.PAGE_THEMES[currentRoute.name];
	newStatusBarStyle = pageTheme.statusBarStyle;
	const backgroundColorFromRoute =
	currentRoute?.params && 'backgroundColor' in currentRoute.params && typeof currentRoute.params.backgroundColor === 'string' && currentRoute.params.backgroundColor;
	// It's possible for backgroundColorFromRoute to be empty string, so we must use "||" to fallback to backgroundColorFallback.
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	currentScreenBackgroundColor = backgroundColorFromRoute || pageTheme.backgroundColor;
	}
	prevStatusBarBackgroundColor.current = statusBarBackgroundColor.current;
	statusBarBackgroundColor.current = currentScreenBackgroundColor;
	if (currentScreenBackgroundColor !== theme.appBG || prevStatusBarBackgroundColor.current !== theme.appBG) {
	statusBarAnimation.value = 0;
	statusBarAnimation.value = withDelay(300, withTiming(1));
	}
	// Don't update the status bar style if it's the same as the current one, to prevent flashing.
	// Force update if the root status bar is back on active or it won't overwirte the nested status bar style
	if ((!didForceUpdateStatusBarRef.current && !prevIsRootStatusBarEnabled && isRootStatusBarEnabled) || newStatusBarStyle !== statusBarStyle) {
	updateStatusBarAppearance({statusBarStyle: newStatusBarStyle});
	setStatusBarStyle(newStatusBarStyle);
	if (!prevIsRootStatusBarEnabled && isRootStatusBarEnabled) {
	didForceUpdateStatusBarRef.current = true;
	}
	}
	},
	[prevIsRootStatusBarEnabled, isRootStatusBarEnabled, statusBarAnimation, statusBarStyle, theme.PAGE_THEMES, theme.appBG, theme.statusBarStyle],
	);

What changes do you think we should make in order to solve the problem?

Set theme-color initial value to the same as the splash background color, #03D47C.

[johncschuster]

@grgia I've asked your in question in QA

[mvtglobally]

@grgia do you need us to check if it's still repro on the current build ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a67f702d8230d48e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[getusha]

the PR is already deployed to staging a few days ago.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix status bar of mWeb Safari doesn't match the splash screen background color #41830

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

@getusha, can you complete the BZ Checklist when you get a moment?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix status bar of mWeb Safari doesn't match the splash screen background color #41830

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

@getusha can you address the BZ Checklist when you get a moment? Thank you!

[johncschuster]

@getusha bump on the checklist! 🙏

[johncschuster]

Payment Summary

@bernhardoj requires payment automatic offer (Contributor) - PAID
@getusha requires payment automatic offer (Reviewer) - PAID

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a It seems like we missed an edge case after implementing the dark mode. I was able to reproduce this on older builds.
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. I don't think this affects any flow, it's a minor bug
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[getusha]

@johncschuster I will request the payment in newdot

[johncschuster]

@getusha Great! Thanks for your contributions!

[johncschuster]

I chatted with @getusha via Slack DM, and it sounds like we're going to continue paying through Upwork on issues assigned to them before 2024-05-25. (cc @mallenexpensify)

I'm going to pay this one via Upwork.

[johncschuster]

This has now been paid. Thanks, everyone!

[johncschuster]

Whoops. I didn't mean to reopen this.