[HOLD for payment 2024-06-28] [$250] Android - Onboarding - Onboarding modal can be dismissed by tapping back button or swiping

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-5
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal team

Action Performed:

1. Open the app and log in with a new account
2. After the onboarding modal appears, swipe left (Pixel) or use the device back button

Expected Result:

The modal is still open and not dismissed

Actual Result:

The onboarding modal is dismissed

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460920_1713999348378.video_2024-04-24_18-55-27.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013838a59a378265e1
• Upwork Job ID: 1785688303987118080
• Last Price Increase: 2024-05-15

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[zanyrenney]

trying to figure out if this is desired.

[zanyrenney]

@dubielzyk-expensify can you clarify?

[dubielzyk-expensify]

Great find. You're not supposed to be able to dismiss the modal so this is a bug 👍

[zanyrenney]

Thanks @dubielzyk-expensify ⭐

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013838a59a378265e1

[zanyrenney]

adding the external label/

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[skyweb331]

@zanyrenney
so if user does not complete the onboarding, user should be stuck in onboarding modal?
For now, I am working on #40876 (comment) which is blocking onboarding modal when user has completed it and it seems like this is vice-versa.

If so, I will submit the proposal.

FYI, this happens for all devices, not only android. You can dismiss the onboarding modal by clicking back button on chrome too.

[melvin-bot]

@sobitneupane, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

[zanyrenney]

As per @dubielzyk-expensify above, you're not supposed to be able to dismiss this. So you're correct they should be "stuck" in onboarding modal I think.

@dubielzyk-expensify that does seem a bit restrictive, so just checking that is correct?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sobitneupane @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[zanyrenney]

bump @dubielzyk-expensify please could you let me know?

[dubielzyk-expensify]

@dubielzyk-expensify that does seem a bit restrictive, so just checking that is correct?

Yes that is correct. There's a whole internal thread about it, but basically boils down to this is key information for users to have a good experience on Expensify. This is the only place we use this pattern and it's not considered uncommon outside of Expensify in terms of modal behavior.

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Block Onboarding modal dismiss on android #42818

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @skyweb331 requires payment (Needs manual offer from BZ)
• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

making daily to action tomorrow

[zanyrenney]

@skyweb331 looks like you never accepted the job so can't pay this out.

[zanyrenney]

Job now closed (as been almost 2 months) resending another offer

[zanyrenney]

cannot find a "skyweb" on UW:

[skyweb331]

@zanyrenney please send an offer to this: https://www.upwork.com/freelancers/~019e5171478d2a22f7

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @skyweb331 paid $(AMOUNT) via Upwork (LINK)
• Reviewer: @sobitneupane owed $250 via NewDot

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1785688303987118080/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@rlinoz, @skyweb331, @sobitneupane, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[zanyrenney]

not overdue - waiting on @skyweb331 to accept

[zanyrenney]

Payment Summary
Upwork Job

ROLE: @skyweb331 paid $250 via Upwork (LINK)
Reviewer: @sobitneupane owed $250 via NewDot - please request!

[JmillsExpensify]

$250 approved for @sobitneupane