Sign up - An error appears in Concierge chat when pass onboarding modal with spaces

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:*(https://expensify.testrail.io/index.php?/cases/view/2616817)
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign up new Gmail account
2. On onboarding modal click on the "Chat and split bills with friends" option (or another non-ws option)
3. Enter space in First and Last name fields and click Continue
4. Dismiss video

Expected Result:

No errors in Concierge chat

Actual Result:

There are errors in Concierge chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461798_1714061860637.bandicam_2024-04-25_19-09-56-543.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[marcaaron]

@francoisl maybe somehow related to #38414?

We should ask QA what account they used.

I tried to repro on staging and could not.

However, I did see OpenReport getting called over and over again - super weird...

2024-04-25_12-44-58.mp4

[marcaaron]

Asking for re-test here. So far, I am not sure I would block the deploy on it unless it's reliably reproducible. But also looks like a server issue.

[francoisl]

I'm able to reproduce on dev, the backend is returning 402 Missing firstName. I'm not 100% sure anymore about the requirement to enter a first and last name, bringing it to discussion in Slack here.

[francoisl]

@marcaaron check out #41047. We'll need a backend change to allow blank last names, I'll send you a PR shortly as well but then we won't need to block the deploy on that.

[kavimuru]

Error message is still reproducible. But now first name is required and throws error if not entered.

empty.name.mp4

[francoisl]

This is normal for now, see this note in the PR (it's easy to miss it I guess)

Note: at the moment, if you don't enter a last name, you will get an error. This will require a backend change but we don't need to block on this.

We already have a backend change in review to fix this, but for now we can mark this as passing.

[melvin-bot]

This issue has not been updated in over 15 days. @marcaaron eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@marcaaron, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.