[Awaiting Payment May 15th] [QBO] advanced configuration: selected accounts are not selected after Relogin

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-2
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Found when validating PR : #40718
Email or phone of affected tester (no customers): applausetester+yuriy.qbo.check1@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Log into New Expensify with an account that is on the accounting beta
2. Enable Accounting feature on the More Features page
3. Go to the Accounting screen and connect to QBO
4. After the connection is established, click Advanced
5. Enable "Sync reimbursed reports"
6. Click Quickbooks Online account
7. Check that you see the list of accounts from QBO whose types are either "Bank" or "Credit card"
8. Select one of the account from the list
   9.Go back and click "Invoice collection account"
9. Check that you see the list of accounts from QBO whose types are either "Bank" or "Other Current Assets"
10. Select one of the accounts from the list
11. Log out from New Expensify
12. Log into New Expensify again and double confirm that the selected accounts in the previous steps are still selected on the Advanced configuration screen

Expected Result:

QuickBooks bill payment account and QuickBooks invoice collections account are still selected after relogin (QBO advanced configuatrion)

Actual Result:

QuickBooks bill payment account and QuickBooks invoice collections account selector are empty after relogin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462696_1714127932366.Screen_Recording_2024-04-26_at_13.30.23.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[mountiny]

This si behind beta so not a blocker

cc @hayata-suenaga @aldo-expensify @trjExpensify @teneeto @narefyev91

[trjExpensify]

I'll wait for @aldo-expensify to come online later, but I think this is going to be fixed by his PRs for Import and Sync etc.

[melvin-bot]

@aldo-expensify, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hayata-suenaga]

I'll wait for @aldo-expensify to come online later, but I think this is going to be fixed by his PRs for Import and Sync etc.

Hmmm, this does't seem to be related to Sync or Import stuff. This is just configuration values (i.e. account IDs) not being saved. What do you think, @aldo-expensify? 😄

[aldo-expensify]

This may have been because of the server errors not handling some "settingNames". Is this still reproducible?

[hayata-suenaga]

ah that makes sense. Let me know @trjExpensify if you encounter this issue again during your testing 🙇

[trjExpensify]

I'm trying to retest this and now I can't toggle sync reimbursed reports on at all to see these accounts now:

Uncaught TypeError for TaskQueue. Cannot read properties of undefined (reading 'id')

[aldo-expensify]

Uncaught TypeError for TaskQueue. Cannot read properties of undefined (reading 'id')

hmm I don't see that error and it works for me:

Screen.Recording.2024-05-01.at.2.59.18.PM.mov

Does this happen if you try in a fresh new workspace?

[trjExpensify]

This was a fresh workspace I created. I'll move to a new account and start over.

Edit: If I ever get a magic code

[aldo-expensify]

This was a fresh workspace I created. I'll move to a new account and start over.

You are testing in staging, right?

[trjExpensify]

Yep! Same result with a fresh workspace and account when clicking Sync reimbursed reports toggle:

Also, our friend country came to the party when I clicked the Import page

[aldo-expensify]

Also, our friend country came to the party when I clicked the Import page

Again! I'll check that

[ikevin127]

⚠️ Automation failed -> this should be on [HOLD for Payment [2024-05-15]] according to today's production deploy from #41530 (comment).

cc @trjExpensify (not sure if you'll handle payment here)

[trjExpensify]

I can do! Assigned you, and updated the title!

[melvin-bot]

@trjExpensify @ikevin127 @aldo-expensify @hayata-suenaga this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ikevin127]

@trjExpensify Is anything else needed from my side in order for the payment to be issued today ?

[trjExpensify]

Offer sent

[trjExpensify]

Payment summary as follows:

$250 to @ikevin127 for the C+ review

[trjExpensify]

Paid!