-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-08] [HOLD for payment 2024-05-06] [$250] Track expense - Education video is displayed in public room when viewed anonymously #41148
Comments
Triggered auto assignment to @thienlnam ( |
Triggered auto assignment to @kevinksullivan ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this bug might be related to #vip-vsb |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?We do not check for anonymous user before opening educational modal: App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Lines 325 to 327 in 05fd715
What changes do you think we should make in order to solve the problem?Put the educational modal navigation inside Fixing 1 will fix 2. What alternative solutions did you explore? (Optional)NA |
I don't think the issue is with showing the educational video, but why is the RHP distorted after dismissing the video. Could we address that issue? |
This also was added in #40675 |
@tienifr any idea on this one? |
cc @rushatgabhane as well |
Adding the external label since @rushatgabhane @tienifr seem to be offline. |
Job added to Upwork: https://www.upwork.com/jobs/~01737d06f4b632dcb2 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 ( |
Loll, I thought this was going to be external for us to work on😆 |
Yeahh, I made it external to see if there's a better way to check once the animation is done instead of the setTimeout. I just deployed this fix right now since the deploy blocker is time sensitive but I still think we could explore a better way to do it since sometimes rendering the animation will take longer. I might keep this issue for @rushatgabhane and @tienifr to chime in as well since they were the original authors but I'll circle back on that. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-06. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Adding @allroundexperts for reviewing the PR |
@tienifr and @rushatgabhane, we merged this fix here but not sure if this is the best way to go about it. Do you guys have any other ideas that are more dependent on render/animation time rather than a constant timeout? |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-08. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@kevinksullivan)
|
Payment summary all set for @allroundexperts . Can you finish out the steps above and then I'll close this? Thanks! |
Waiting on @allroundexperts for the steps above |
^ (Trying to remove the overdue label) |
I don't think if a checklist is needed here. This was a bug with no definite root cause and as such, we just used a timeout to solve it. A regression test would be an overkill here as well. |
Payment summary:
|
$250 approved for @allroundexperts |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
The RHP should not be distorted
Actual Result:
After dismissing the modal, the RHP is distorted
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6463788_1714232319574.20240427_233506.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexpertsThe text was updated successfully, but these errors were encountered: