Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAY] 2 copies of react-pdf are included in the web js bundle #41237

Closed
4 of 6 tasks
janicduplessis opened this issue Apr 29, 2024 · 9 comments
Closed
4 of 6 tasks

[PAY] 2 copies of react-pdf are included in the web js bundle #41237

janicduplessis opened this issue Apr 29, 2024 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@janicduplessis
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Latest
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @janicduplessis
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1714407724836209?thread_ts=1714247539.428689&cid=C05LX9D6E07

Action Performed:

  • Inspect js bundle using the analyze-packages script
  • See that there are 2 copies of react-pdf

Expected Result:

There should only be 1 copy of react-pdf

Actual Result:

There are 2 copies of react-pdf

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

@janicduplessis janicduplessis added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mallenexpensify
Copy link
Contributor

Assigned to @ahmedGaber93 as they're reviewing the PR.

@roryabraham
Copy link
Contributor

roryabraham commented May 1, 2024

Reviewed and merged the PR after being tagged in slack

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

This issue has not been updated in over 15 days. @mallenexpensify, @ahmedGaber93, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@janicduplessis
Copy link
Contributor Author

janicduplessis commented May 27, 2024

This has been merged already, can we close it?

@mallenexpensify mallenexpensify added Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Reviewing Has a PR in review Monthly KSv2 labels May 29, 2024
@mallenexpensify
Copy link
Contributor

Thanks for the ping @janicduplessis . @ahmedGaber93 , you're due $250 here, right? Assuming so, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~012eb7ba95c3bdb089
I

@mallenexpensify mallenexpensify changed the title 2 copies of react-pdf are included in the web js bundle [PAY] 2 copies of react-pdf are included in the web js bundle May 29, 2024
@ahmedGaber93
Copy link
Contributor

Yes, right. Offer accepted thanks @mallenexpensify

@mallenexpensify
Copy link
Contributor

Contributor+: @ahmedGaber93 paid $250 via Upwork.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants