Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 23rd May] [QAB] 404 when clicked if your quick action button is set to a workspace that’s since been deleted #41467

Closed
6 tasks done
trjExpensify opened this issue May 2, 2024 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@trjExpensify
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.69-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714588862011939?thread_ts=1714400587.768059&cid=C036QM0SLJK

Action Performed:

  1. Go to global create > Submit expense > choose a workspace > confirm
  2. Reopen global create
  3. Verify you have the quick action button set to that workspace
  4. Switch over to OldDot and delete the workspace (there's an unrelated bug preventing this action in NewDot natively right now)
  5. Switch back to NewDot (maybe refresh if it's taking a hot minute to reflect that action)
  6. Reopen global create
  7. Click the quick action button
  8. Observe the 404 page in the RHP

Expected Result:

  1. The quick action button should be able to be clicked
  2. After taking the first page action (BNP, receipt scan, enter distance) a participant selector should appear
  3. At the top of the participant selector there should be text that reads: "You no longer have access to %reportName%. Pick a new destination for your quick action.”
image

Actual Result:

Clicking the quick action button results in a 404 not found page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
No, a workspace can't be undeleted. They can "reset" their quick action button choice by using one of the main options in global create.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-05-01_19-27-01.mp4

View all open jobs on GitHub

@trjExpensify trjExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 2, 2024
Copy link

melvin-bot bot commented May 2, 2024

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@trjExpensify
Copy link
Contributor Author

Talking to Alberto about this, there's a case where the user logs out and the QAB report isn't loaded anymore. So in that case, we'll:

  1. Show Update destination in the subtext as we don't have the report name anymore
  2. Don't use copy in the participant selector that includes the report name because we might not have it.

image

@trjExpensify
Copy link
Contributor Author

Merged, awaiting a deploy!

@rojiphil
Copy link
Contributor

Automation got missed here too.
This was deployed to production on 09 May.
@trjExpensify Please note. This is pending payment to me as C+ reviewer.

@trjExpensify trjExpensify added Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 and removed Reviewing Has a PR in review Weekly KSv2 labels May 23, 2024
@trjExpensify trjExpensify changed the title [QAB] 404 when clicked if your quick action button is set to a workspace that’s since been deleted [Awaiting Payment 23rd May] [QAB] 404 when clicked if your quick action button is set to a workspace that’s since been deleted May 23, 2024
@trjExpensify
Copy link
Contributor Author

Nice! Payment summary as follows:

  • $250 to @rojiphil for the C+ review of the PR

Regression tests for QAB have been added centrally. Thanks, offer sent!

@trjExpensify
Copy link
Contributor Author

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Archived in project
Development

No branches or pull requests

3 participants