Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log time to complete api requests #41708

Closed
janicduplessis opened this issue May 7, 2024 · 2 comments
Closed

Log time to complete api requests #41708

janicduplessis opened this issue May 7, 2024 · 2 comments
Assignees
Labels
Monthly KSv2 Reviewing Has a PR in review

Comments

@janicduplessis
Copy link
Contributor

Problem

When analyzing logs it is hard to see if an issue is related to slow network requests. It is technically possible to calculate the time network requests took by taking the start and end timestamps, but this is very time consuming and almost impossible if you do not know which request could be slow.

Solution

Add the time it took for the request to complete in the "Finished API request" log. This will allow spotting slow network requests easily while glancing at the logs.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels May 7, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

This issue has not been updated in over 15 days. @janicduplessis, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@janicduplessis
Copy link
Contributor Author

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants